cronbuild fails if there weren't any new commits in the last week

DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform

Other

2.65k stars 560 forks source link

cronbuild fails if there weren't any new commits in the last week #2890

Open derekbruening opened 6 years ago

derekbruening commented 6 years ago

https://travis-ci.org/DynamoRIO/drmemory/jobs/355896386

0.01s$ git tag $GIT_TAG -a -m "Travis auto-generated tag for build $TRAVIS_BUILD_NUMBER."
fatal: tag 'cronbuild-1.11.17596' already exists
The command "git tag $GIT_TAG -a -m "Travis auto-generated tag for build $TRAVIS_BUILD_NUMBER."" failed and exited with 128 during .

Should add today's date to the tag or sthg? Or just let it fail: there's nothing new so no need for a new package?

Carrotman42 commented 6 years ago

I think adding the date would be useful in general.

derekbruening commented 6 years ago

Note that the VERSION_NUMBER has several limitations: for the Windows DLL resource section it is 4 16-bit integers; clang on Mac limits each digit but the major version to < 256. So it is not a freeform value, and it is nice to have the tag match it. Adding something just to the tag that is not in the version may be confusing when trying to distinguish two binary package files which do not have the tag anywhere inside them. The 4th version number is BUILD_NUMBER which perhaps could be used here, setting it to a day-based date value.