search

DynamoRIO / dynamorio

Dynamic Instrumentation Tool Platform
Other
2.67k stars 566 forks source link

AArch64: Add 64-bit atomic load/store instructions to decoder #4692

Open egrimley opened 3 years ago

egrimley commented 3 years ago

The instructions LD64B, ST64B, ST64BV and ST64BV0 can access more than 8 general-purpose registers and are therefore not safely handled by the OP_xx fall-back. They must therefore be added to the decoder.

AssadHashmi commented 3 years ago

Related to #4688 and #2626.

AssadHashmi commented 3 years ago

These are ARMv8.7 instructions (https://developer.arm.com/documentation/ddi0487/latest). I'm not aware of any hardware which implements the v8.7 FEAT_LS64 feature at present. We currently endeavour to support DynamoRIO up to and including v8.2, with SVE on the roadmap. @derekbruening perhaps better to leave implementation until h/w is available?

derekbruening commented 3 years ago

OK, it makes sense to lower the priority in that case.