search

E3SM-Project / Omega

Next generation ocean model within E3SM
https://docs.e3sm.org/Omega/omega
Other
4 stars 5 forks source link

Fix warning when `RunDuration` and `StopTime` are inconsistent #125

Closed xylar closed 2 months ago

xylar commented 2 months ago

This warning should only be displayed if StopTime is not 'none'.

Checklist

xylar commented 2 months ago

Testing

When running the manufactured solution test case in Polaris, I no longer see the warning in the log file when I use this YAML file:

Omega:
  TimeManagement:
    StartTime: 0001-01-01_00:00:00
    StopTime: none
    RunDuration: 0000_10:00:00.000 #0000_02:00:00.000
    CalendarType: No Leap
  TimeIntegration:
    TimeStepper: Forward-Backward
    TimeStep: 0000_01:40:00.000
  Dimension:
    NVertLevels: 60
  Decomp:
    HaloWidth: 3
    DecompMethod: MetisKWay
  State:
    NTimeLevels: 2
  Advection:
    FluxThicknessType: Center
  Tendencies:
    ThicknessFluxTendencyEnable: true
    PVTendencyEnable: true
    KETendencyEnable: true
    SSHTendencyEnable: true
    VelDiffTendencyEnable: false
    ViscDel2: 1.0e3
    VelHyperDiffTendencyEnable: false
    ViscDel4: 1.2e11
xylar commented 2 months ago

CTests are all failing on Chrysalis but I don't think that's because of this PR.

xylar commented 2 months ago

The same CTests are failing on Chrysalis with the current develop:

The following tests FAILED:
      5 - DECOMP_TEST (Failed)
      6 - HALO_TEST (Failed)
      7 - DIMENSION_TEST (Failed)
      8 - HORZMESH_TEST (Failed)
      9 - HORZOPERATORS_PLANE_TEST (Failed)
     10 - HORZOPERATORS_SPHERE_TEST (Failed)
     11 - AUXVARS_PLANE_TEST (Failed)
     12 - AUXVARS_SPHERE_TEST (Failed)
     13 - AUXSTATE_TEST (Failed)
     14 - IO_TEST (Failed)
     16 - FIELD_TEST (Failed)
     17 - TEND_PLANE_TEST (Failed)
     18 - TEND_SPHERE_TEST (Failed)
     19 - TENDENCIES_TEST (Failed)
     20 - STATE_TEST (Failed)
     23 - TIMESTEPPER_TEST (Failed)
     25 - DRIVER_TEST (Failed)

Seems to at least partially be a YAML issue.

xylar commented 2 months ago

@mark-petersen, I pinged you on Slack but I'll cover my bases by pinging you here. Could you look into why CTests (from develop) are failing on Chrysalis? I used this utility: https://github.com/E3SM-Project/polaris/tree/main/utils/omega/ctest

brian-oneill commented 2 months ago

The same CTests are failing on Chrysalis with the current develop:

The following tests FAILED:
    5 - DECOMP_TEST (Failed)
    6 - HALO_TEST (Failed)
    7 - DIMENSION_TEST (Failed)
    8 - HORZMESH_TEST (Failed)
    9 - HORZOPERATORS_PLANE_TEST (Failed)
   10 - HORZOPERATORS_SPHERE_TEST (Failed)
   11 - AUXVARS_PLANE_TEST (Failed)
   12 - AUXVARS_SPHERE_TEST (Failed)
   13 - AUXSTATE_TEST (Failed)
   14 - IO_TEST (Failed)
   16 - FIELD_TEST (Failed)
   17 - TEND_PLANE_TEST (Failed)
   18 - TEND_SPHERE_TEST (Failed)
   19 - TENDENCIES_TEST (Failed)
   20 - STATE_TEST (Failed)
   23 - TIMESTEPPER_TEST (Failed)
   25 - DRIVER_TEST (Failed)

Seems to at least partially be a YAML issue.

Just ran the ctests on Chrysalis with the develop branch and I'm not seeing these failures

xylar commented 2 months ago

Thank @brian-oneill !

xylar commented 2 months ago

@brian-oneill, that's odd about CTests working for you and not for me. If I'm the only one seeing the issue, I can try again when I get back from vacation later this week. @mark-petersen, I'd still appreciate knowing if you also don't see issues.

xylar commented 2 months ago

I see my mistake. I didn't update the utility to do this new step: https://github.com/E3SM-Project/Omega/blob/develop/components/omega/doc/devGuide/QuickStart.md?plain=1#L152-L154

I think that copying should happen automatically as part of the build and I have just requested that in #126.

xylar commented 2 months ago

Sorry @brian-oneill and @mark-petersen for the confusion.