E3SM-Project / Omega

Next generation ocean model within E3SM
https://docs.e3sm.org/Omega/omega
Other
4 stars 5 forks source link

Copy certain coordinate arrays to the device #167

Closed hyungyukang closed 1 week ago

hyungyukang commented 1 week ago

This tiny PR copies certain coordinate arrays (XCell, YCell, XEdge, YEdge) required for the test cases (e.g., the manufactured solution) to the device.

This could be incorporated into the manufactured solution PR; however, separating it for debugging and testing purposes would be more advantageous.

Passed unit tests on Frontier using both CPU and GPU.

brian-oneill commented 1 week ago

Passes unit tests on Chyrsalis, and Perlmutter CPU & GPU. Minor change, approving based on inspection.

mark-petersen commented 1 week ago

Thanks! Looks good. And thanks @brian-oneill for the quick review.