search

EAPD-DRB / OG-PHL

Overlapping-generations macroeconomic model for evaluating fiscal policy in the Philippines
https://eapd-drb.github.io/OG-PHL
Creative Commons Zero v1.0 Universal
6 stars 38 forks source link

Added trade.py and updated constants.py #27

Closed rickecon closed 1 month ago

rickecon commented 1 month ago

This PR starts adding trade to OG-PHL.

cc: @jdebacker @SeaCelo

SeaCelo commented 1 month ago

Hi @rickecon

Thank you for your work on this PR. It seems that the content appears more like a placeholder rather than a complete and documented solution. Documentation would help us understand the purpose of the changes.

Could you please provide more detailed documentation and ensure that all relevant information is included? This will help us better evaluate the PR and understand its intended use.

also, please remember to make format and the other steps.

Looking forward to your updates.

SeaCelo commented 1 month ago

Let's try this PR again with the full documentation. Closing

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (9201542) to head (74ec833). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ogphl/trade.py 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== - Coverage 70.54% 68.79% -1.76% ========================================== Files 12 13 +1 Lines 275 282 +7 ========================================== Hits 194 194 - Misses 81 88 +7 ``` | [Flag](https://app.codecov.io/gh/EAPD-DRB/OG-PHL/pull/27/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EAPD-DRB) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/EAPD-DRB/OG-PHL/pull/27/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EAPD-DRB) | `68.79% <0.00%> (-1.76%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EAPD-DRB#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.