search

ECP-WarpX / impactx

high-performance modeling of beam dynamics in particle accelerators with collective effects
https://impactx.readthedocs.io
Other
26 stars 20 forks source link

`<cmath>`: Use `std::` C++ Functions #716

Closed ax3l closed 3 days ago

ax3l commented 4 days ago

Only the std:: math functions have overloads for double and float. Without the std:: prefix, we use the C functions, which will when we run ImpactX in single precision cause up and down casts to double (performance penalty).

ax3l commented 3 days ago

Thanks! Yes I did a line-by-line review and touch-up yesterday evening after search-replace-all.