EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

Images dissapear while using Image + text / text + image #113

Open serokicki opened 5 years ago

serokicki commented 5 years ago

Hello,

I've found an issue that every click on Image + text/text + Image resets source of those controls. Function below checks whether we use DynamicImages or not and it either resets our src to "" or replaces with a placeholder.. It happens on each click. main.js:

            if (isDynamic) {
                var width = sel.props.width.get();
                var height = sel.props.height.get();

                var maxWidth = sel.functions.getMaxWidth();

                if (!width || width === "auto") {
                    sel.props.width.set(maxWidth);
                }

                if (!height || height === "auto") {
                    sel.props.height.set(maxWidth);
                }

                src("https://via.placeholder.com/" + sel.props.width.get() + "x" + sel.props.height.get());
            } else if (isDynamicPrev !== isDynamic) {
                resetImage();
            }

            isDynamicPrev = isDynamic;
        });

This is how it appears: I've added couple of image controls and added a random image: image

Then clicked on first one and last one: image

Both ended up with src(uknown): image

Could you please help me with solution for that? Or maybe fast fix?

Thank you in advance.

agnieszkakowalska commented 5 years ago

@gyulanemeth can you please help?

gyulanemeth commented 5 years ago

Hello, thanks for reporting, we are going to address this issue in the next release. In the meanwhile please rollback to a previous release.

gyulanemeth commented 5 years ago

Hello, we have tried to reproduce it several times without any success. Can you please try it again with the newest release?