search

EIDA / wfcatalog

EIDA NG WFCatalog implementation
5 stars 8 forks source link

Webservice response and JSON schema #16

Open damb opened 4 years ago

damb commented 4 years ago

This issue is a follow-up in response to an email from @Jollyfant:

Hi guys,
I don't think we ever changed the schema so it's the most recent version, although it has bugs because the output does not validate on the schema, apparently!

In the JSON schema we need to change for all enums, type: "string", and enum as a seperate object. Maybe an older version of JSON schema did it this way.

The schema should work for the option inlcude=all (all metrics must be returned) and for a single document in the returned array. But the webservice has some additional issues pulling these fields from the DB

  1.  nsamp (service) is called nsam (collector) in the database @ line 1037
  2.  long_record_read is not added to the client output @ line 1066
  3.  event in progress is not added to the client output @ line 1084

and all three are therefore not returned. So these could be fixed in the service.

Hope it helps fixing the bugs!

Best,
Mathijs

Thanks @Jollyfant for your input.

damb commented 3 years ago

@jbienkowski, any updates on this one, here?