g_encapsulation_inactivity_timeout: seconds or milliseconds?

EIPStackGroup / OpENer

OpENer is an EtherNet/IP stack for I/O adapter devices. It supports multiple I/O and explicit connections and includes objects and services for making EtherNet/IP-compliant products as defined in the ODVA specification.

Other

689 stars 262 forks source link

g_encapsulation_inactivity_timeout: seconds or milliseconds? #95

Closed scottnewell closed 7 years ago

scottnewell commented 7 years ago

Line 63 of file ciptcpipinterface.c: the comment specifies the timeout as 120 s, but the code considers it as 120 ms. I suspect 120 s is correct, but I'm unsure. Thoughts?

blacktigersoftware commented 7 years ago

scottnewell -- could you email me at kdavis at rsi-xray dot com? I would like to see how you are using this. I'm in the industrial area, and we were looking at Ethernet/IP for point-to-point communications between various hardware automation boards that we build. No decision has been made but this is far better than spending thousands on the odva spec. lol.

MartinMelikMerkumians commented 7 years ago

Sorry, I was on a business trip, I will look into this issue and your pull request today.

Thanks for your help!

scottnewell commented 7 years ago

blacktigersoftware--email sent! (Twice.)

MartinMelikMerkumians commented 7 years ago

Ok, this issue should be resolved, thanks to your contribution. Thanks @scottnewell