search

EMOD-Hub / EMOD

Source files for building the IDM EMOD disease transmission model.
MIT License
94 stars 41 forks source link

Added Report_HIV_ByAgeAndGender_Collect_Targeting_Config_Data #59

Closed Bridenbecker closed 1 week ago

Bridenbecker commented 1 week ago

Resolves #46

Green https://jenkins.apps.idmod.org/job/EMOD_Builds/job/scons_linux_hiv_regression/5/ https://jenkins.apps.idmod.org/job/EMOD_Builds/job/scons_linux_hiv_sfts/2/

stitova-idm commented 1 week ago

Update: AFter the discussion: you can do Targeting_Config without TargetingLogic, so the argument won't necessarily be the TargetingLogic. This will also look simpler in emodpy as "TargetingLogic" is hidden from the user.

General comment: We call it Report_HIV_ByAgeAndGender_Collect_Targeting_Config_Data and "Matches_TargetingConfig#", but what we are actually collecting/matching is the TargetingLogic and there are potentially multiple TargetingLogics in a TargetingConfig. I think this might be confusing for non-english speakers. It would be nice if the parameter names matched the class name of the thing. "Collect_TargetingLogic_Data" and "Matches_TargetingLogic_Data" since the logics can also come from different targeting configs?