EMU-Compsci-Discord / CompsciBot

A discord bot for a computer science discord server
MIT License
3 stars 3 forks source link

refactor: ♻️ Nate being picky and changing things he doesn't like #20

Closed nstringham closed 2 years ago

nstringham commented 2 years ago

@coxender

nstringham commented 2 years ago

This code does not work as intended.

It is expected that the user can submit a file format that the bot specifies and execute the command without error.

When giving a file for channelparse.csv, the bot specifies to not use an extension and exits. If a file is given without an extension as the bot specifies, the execution of the command crashes.

Is this a regression?

coxender commented 2 years ago

Is this a regression?

Yes

coxender commented 2 years ago

@nstringham This should fix the issues it was causing: https://github.com/nstringham/CompsciBot/pull/1

nstringham commented 2 years ago

I really wish we had tests in this project