search

EOA-team / eodal

Earth Observation Data Analysis Library
https://eodal.readthedocs.io/en/latest/
GNU General Public License v3.0
93 stars 15 forks source link

Feature request: Move the preprocessing functions to a specific folder within EOdal #67

Closed gperich closed 1 year ago

gperich commented 1 year ago

I extracted S2 scenes and did not use a preprocessing function as I thought I was only going to use the 10m bands anyways. Turns out you cannot do that, as I got the following error message: image

I guess that is due to the SCL bands having a native resolution of 20m. Therefore, you need the resampling.

My feature request / idea is now to move the preprocessing functions (in the current examples always preprocess_sentinel2_scenes) to a library within the package EOdal. Maybe call it "userfuns" or "preprocessing_funs" or so. That way, the community could quickly share functions and you wouldn't need to define your own funs all the time.

Good idea or not?

lukasValentin commented 1 year ago

Hi @gperich, true it is the SCL band comes at a native resolution of 20 meters. This means, when datasets need to be merged, there is potential for errors as the one you reported because temporary GeoTiff files are generated. GeoTiff does not allow bands with different pixel sizes.

I admit that this is not documented very well for the time being.

I think the usage of a sub-package within eodal to collect the pre-processing functions is a good idea. Overall, it would be great to also receive some feedback from other users such as @atoparseks, @m-i-g-u-e-l, @orianif or anyone else interested in moving EOdal forward.

lukasValentin commented 1 year ago

Since there has been no activity one this issue for a while, I propose to close it. I feel it might be partly resolved by the work we did on eodal_basetiffs (see here). I'd actually prefer to keep such "custom" code in a separate Python repository to not overload the library.