search

ESIPFed / Geoweaver

boost data pipeline's tangibility, enhance research productivity, reduce work anxiety
https://geoweaver.dev
MIT License
81 stars 44 forks source link

Integrated Monaco-Editor #495

Closed VisheshSaluja closed 6 months ago

VisheshSaluja commented 8 months ago

Integrated Monaco_editor for python resolved the merge conflict DialogBox editor

gokulprathin8 commented 8 months ago

also, if there is a worker thread being spawned, please make sure the thread is killed when the code editor is closed.

gokulprathin8 commented 6 months ago

editing code fails

Uncaught TypeError: Cannot read properties of undefined (reading 'getValue')
    at Object.getCode (gw.process.sidepanel.js:444:42)
    at Object.update (gw.process.sidepanel.js:63:40)
    at Object.editSwitch (gw.process.sidepanel.js:57:12)
    at gw.general.js:23:34
    at dispatch (jquery-1.11.3.min.js:4:8549)
    at r.handle (jquery-1.11.3.min.js:4:5252)

failure to restore history

gw.process.sidepanel.js:444 Uncaught TypeError: Cannot read properties of undefined (reading 'getValue')
    at Object.getCode (gw.process.sidepanel.js:444:42)
    at Object.update (gw.process.sidepanel.js:63:40)
    at Object.editSwitch (gw.process.sidepanel.js:57:12)
    at gw.general.js:23:34
    at dispatch (jquery-1.11.3.min.js:4:8549)
    at r.handle (jquery-1.11.3.min.js:4:5252)

unable to close the history tab on diff view

image
ZihengSun commented 6 months ago

@VisheshSaluja is this PR ready?

VisheshSaluja commented 6 months ago

@ZihengSun It is almost done, trying to get it done as soon as possible the problem is when i am making changes, the old code is breaking the Monaco-Editor. So it is taking time to debug and change it I am left with just one last issue in this, i'll try to get this done by tomorow

ZihengSun commented 6 months ago

Is this ready now? @VisheshSaluja I didn't see any changes after the meeting.

ZihengSun commented 6 months ago

@gokulprathin8 please review this PR when you can, and better get it merged first. I didn't see the issues you mentioned above. Bash process changes are saved correctly.

gokulprathin8 commented 6 months ago

@ZihengSun the file looks like it saved when when you run it, it either does not show the recent changes or if we are making a new process, it shows no such file exists error

image
gokulprathin8 commented 6 months ago

another issue, when I run either python or bash, the output split window does not open automatically.

ZihengSun commented 6 months ago

that is not an issue caused by this pr. Should be addressed separately. That is due to some other issues when I was working on the side panel.

On May 18, 2024 11:20 AM, Gokul Prathin @.***> wrote:

another issue, when I run either python or bash, the output split window does not open automatically.

— Reply to this email directly, view it on GitHubhttps://github.com/ESIPFed/Geoweaver/pull/495#issuecomment-2118855748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEEFH22RMYHO37HBJPFT2FDZC5WSJAVCNFSM6AAAAABFPW7HB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHA2TKNZUHA. You are receiving this because you were mentioned.Message ID: @.***>

VisheshSaluja commented 6 months ago

@gokulprathin8 I tested for the issue regarding saving the code and running it, i am not having that issue During the meeting with professor, he tested the editor and didn't face any similar issue as well

VirginiaJRS commented 6 months ago

it might be a bad merge in the browser. Clean the browser before testing might help

On Sat, May 18, 2024, 11:45 AM Vishesh Saluja @.***> wrote:

@gokulprathin8 https://github.com/gokulprathin8 I tested for the issue regarding saving the code and running it, i am not having that issue During the meeting with professor, he tested the editor and didn't face any similar issue as well

— Reply to this email directly, view it on GitHub https://github.com/ESIPFed/Geoweaver/pull/495#issuecomment-2118862371, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHQVERQKO5WMC6YSFE6C4DZC5ZRDAVCNFSM6AAAAABFPW7HB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHA3DEMZXGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

gokulprathin8 commented 6 months ago

bash-recording

just making sure this is what your testing.

gokulprathin8 commented 6 months ago

let me know if the above works for you. If yes, ill aprove and we can merge this! @VisheshSaluja

ZihengSun commented 6 months ago

@gokulprathin8 I believe that is a different issue. And the process run fails because you are trying to run Bash script on Windows, which is impossible. We should alert people on Window that Shell doesn't work on your OS.

But that is a different request. It has nothing to do with this PR.

Please test it on Mac or Linux and check if it works for you.

gokulprathin8 commented 6 months ago

oops. i was testing this on WSL, looks like its a WSL problem. Merging.