search

ESLyric / feedback

Feedback for ESLyric
13 stars 0 forks source link

[Feature Request] Apply offset to Timestamps #155

Open ngs428 opened 6 months ago

ngs428 commented 6 months ago

Apply offset tag to Timestamps Some of my players don't support and offset value, so having the ability to apply the offset value to the individual timestamps would be very helpful. This feature is present in OpenLyrics and works very well.

In ESLyrics you can hit "ctrl" and "left click" to drag and set the offset, seems to work well, but then following that up with applying the offset value to each timestamp and then removing the offset value at the top of the lyrics would be great.

OpenLyrics is shown below. You listen to the song and when it hits the line you need, you press the "Sync Line using offset tag" button, that is similar to your CTRL left click, then you would press the "Apply offset to timestamps" button to add the offset to the timestamps and remove the offset value.

OpenLyrics

ESLyric commented 4 months ago

try the alpha version. access via the editor's menubar https://github.com/ESLyric/release/releases/tag/1.0.0.1010

ngs428 commented 4 months ago

Thank you for the update! Applying the offset works great!

On a similar note, in ESLyrics you can hit "ctrl" and "left click" to drag and set the offset, Where is this offset saved to? I hit "ctrl" and "left click" to drag and set the offset, then right click, adjust offset, the offset is there, then I hit OK. The offset value is not saved to the top of the .lrc file and also the timestamps are not changed. Ideally the offset would be applied to the top of the file, then this new command could be used to apply to the timestamps. Or the timestamps could be adjusted automatically per what that offset is.

Is there another way to do this or am I missing something?

ESLyric commented 4 months ago

‘offset’ was saved in memory default and you should use 'Save' in the context menu to save to original location(file or meta) or save to configured location if is online lyric.

ngs428 commented 4 months ago

I tried the “Save” originally and it did not save to the .lrc file. Can you please test to make sure that is working properly?

ESLyric commented 4 months ago

Seems to be broken. wait for fix

ngs428 commented 3 months ago

Works great in https://github.com/ESLyric/release/releases/tag/1.0.0.1013

Thanks!