search

EWSoftware / VSSpellChecker

A Visual Studio spell checker editor extension that checks the spelling of comments, strings, and plain text as you type. Supports configuration and various languages.
Other
377 stars 65 forks source link

Can you add support for Makefile projects? #290

Closed pipsqik closed 1 year ago

pipsqik commented 1 year ago

When selecting an item or items from the Solution Explorer when the project is a 'Makefile project' I just get the Spell Check Tool Window open with a message: Load a solution with projects to spell check.

The same happens if I select the menu item: Spell Check Entire Solution.

Using the tool on open documents is great though!

regards Andrew

EWSoftware commented 1 year ago

It would depend on whether or not it's accessible through the API and whether or not the tool window gets the proper notification events when such a project is loaded. Do you have an example I can try it with?

pipsqik commented 1 year ago

I don't have an immediate example I can send you, but I'll create one and get back to.

Andrew

On Thu, 1 Jun 2023, 20:02 Eric Woodruff, @.***> wrote:

It would depend on whether or not it's accessible through the API and whether or not the tool window gets the proper notification events when such a project is loaded. Do you have an example I can try it with?

— Reply to this email directly, view it on GitHub https://github.com/EWSoftware/VSSpellChecker/issues/290#issuecomment-1572622575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGB2PYU5TELWKHGQQLH5KTXJDRMZANCNFSM6AAAAAAYXH3SEE . You are receiving this because you authored the thread.Message ID: @.***>

pipsqik commented 1 year ago

Here's a trivial example I created.
SpellCheckerCMake.zip

Once you've unzipped it, go to visual studio and instead of opening a solution, open the src folder.

EWSoftware commented 1 year ago

I opened the folder to load the example. It then prompted me to add support for make files. However, even after doing that I still had to open the folder as there didn't appear to be any option to open the make file itself as a solution or project type. With no project system behind it, it doesn't generate the normal solution/project events that are needed to see them in the tool window. As such, I don't think this can be supported.

pipsqik commented 1 year ago

That's a shame - thanks for investigating anyway.

On Monday, 19 June 2023 at 17:11:05 BST, Eric Woodruff ***@***.***> wrote:

I opened the folder to load the example. It then prompted me to add support for make files. However, even after doing that I still had to open the folder as there didn't appear to be any option to open the make file itself as a solution or project type. With no project system behind it, it doesn't generate the normal solution/project events that are needed to see them in the tool window. As such, I don't think this can be supported.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>