Download/saving sample description only possible with filled out processing template

EarthSystemDiagnostics / cpt-picarr

MIT License

1 stars 0 forks source link

Download/saving sample description only possible with filled out processing template #40

Closed thomas-muench closed 5 years ago

thomas-muench commented 5 years ago

To avoid user errors, and to make clear what user input is needed, the downloading/saving on the server of a filled out sample description must not be possible without filling out the accompanying processing template.

Hence, for saving the sample description, it must be needed to

[x] include all standards of the sample description in the processing template (according to Identifier 1)
[x] fill out all columns for each of these standards (flag buttons + true values)
[x] make sure that setting on the quality control flag for one standard automatically switches off the other processing flags.

twollnik commented 5 years ago

@thomas-muench please take a look at the current version and let me know if this works for you.

thomas-muench commented 5 years ago

Thanks for this - this seems to do now what we want; very nice work!!

I only have two minor things:

Can we make the error message more prominent? E.g. red text, bigger, ...? It's easy to overlook now and then you start to look for the download button...
Do we want an error if a standard is not given any options, i.e. no processing options and neither treated as quality control? Currently, this works without an error, but this actually only makes sense if the standard is from the first block, since then it is used for getting the memory coefficients.

twollnik commented 5 years ago

Regarding your points:

Yes, of course.
We could do that. However I would prefer to focus on the more pressing tasks for the time being.