search

EarthWorksOrg / EarthWorks

Other
3 stars 3 forks source link

Other changes after cesm3_0_beta02 update #73

Closed gdicker1 closed 2 months ago

gdicker1 commented 2 months ago

This is a PR to incorporate other changes to EarthWorks. These include things like performance timers and input file changes.

Please suggest any other changes you can think of!

NOTE: the code in this PR may not fetch cleanly until all Sub-PRs are merged and this PR is moved out of draft.

gdicker1 commented 2 months ago

Sub-PRs:

Timers

Input files

Other/Miscellaneous

gdicker1 commented 2 months ago

At this point I think everything is in place for this PR and the sub-PRs. If anyone wants to spot-check, that would be appreciated. I'll be running tests on this soon and hopefully merging before Derecho starts maintenance.

Adding @sherimickelson and @areanddee for the typical notify and @dazlich as an optional tester (his choice).

gdicker1 commented 2 months ago

Testing the ew-pr category using the code version in 091ec56 against runs of the same test category using the ew2.3.005 tag as baseline (results of https://github.com/EarthWorksOrg/EarthWorks/pull/72 ) revealed:

All tests had failures when comparing current namelists (NLCOMP) and run outputs (DIFF) to the previous version. These were expected due to the change in input data.

At this point there is one other change I'd like to make to the tests, and this PR is ready to merge!

EDIT: I hadn't noticed that the CHAOS2000dev nvhpc test failed during the run with limited output but hit wallclock limit. I'm currently investigating before this is ready to merge again.

gdicker1 commented 2 months ago

The CHAOS2000dev nvhpc test ran successfully after re-submitting (no modifications). I think this was just a system glitch and not worth more thought.

Ready to merge again! I'm looking to do so at the end of the day (~5pm MT).

@sherimickelson @areanddee