search

Earthcomputer / multiconnect

A mod to connect to multiple Minecraft server versions
Other
463 stars 52 forks source link

[1.19] → [1.12.2] String too big (issue with long nicknames) #376

Open Felix14-v2 opened 2 years ago

Felix14-v2 commented 2 years ago

Description When sending too long messages or when trying to log in under a long nickname, you get this unpleasant error and disconnection from the server. The latest version of Multiconnect (1.6 beta 14) was used.

Additional [Demo] latest.log Krypton#80

Earthcomputer commented 2 years ago

This is not caused by multiconnect. This is a client-side error caused by a mod sending a too long chat message

Felix14-v2 commented 2 years ago

This is not caused by multiconnect. This is a client-side error caused by a mod sending a too long chat message

So... What about large nicknames? Tested with just Multiconnect, LazyDFU and AuthMe.

Earthcomputer commented 2 years ago

It's not a nickname that's causing this, it's a chat message. It's the vanilla packet serialization throwing this error, which multiconnect does not use. Even if it did, the normal way to construct a vanilla packet truncates the string at 256 characters, so there's something funky going on here, maybe one of your mods is modifying chat messages as they're being sent. From a quick glance, google-chat maybe?

Earthcomputer commented 2 years ago

It's possible that when you tested with just those three mods, you got a different error that is not in your initial report.

Felix14-v2 commented 2 years ago

maybe one of your mods is modifying chat messages as they're being sent. From a quick glance, google-chat maybe?

None of them led to the same problem in the test instance, as well as some other mods I have tested. However, the error itself did not occur, so I will continue to look for a conflicting mod.

It's possible that when you tested with just those three mods, you got a different error that is not in your initial report.

Nope, error message was the same even with only Multiconnect and Authme (+Fabric API) installed: latest.log Also tested even without Authme with only multiconnect from TL Legacy launcher: latest.log

Earthcomputer commented 2 years ago

That's not the same error

Felix14-v2 commented 2 years ago

🤔 However, there is still a problem with long nicknames. image

Felix14-v2 commented 2 years ago

However, the error itself did not occur, so I will continue to look for a conflicting mod.

Found it! It was Krypton incompatibility. latest.log

Felix14-v2 commented 2 years ago

Should it be reopened? And by the way, should I open a separate issue for the returned problem with dropping chunks?

Earthcomputer commented 2 years ago

Please report the Krypton incompatibility to the Krypton repository, in the mean time I will add a breaks entry to the fabric.mod.json to better inform users of the current situation there.

In general, each issue should have its own, well, issue, so that I can track whether I have fixed each one individually. So yes, please report the dropping chunks issue separately, after searching to make sure that the issue doesn't already exist.

creeper123123321 commented 2 years ago

This probably can be reproduced without multiconnect, just type a big string with some random non-ascii chars when using Krypton

Felix14-v2 commented 1 year ago

Still an issue in 1.6 beta-26