search

EasyRPG / packaging

Config files used for different distributions to build EasyRPG packages
7 stars 2 forks source link

MP3 patent issues in some distributions #3

Closed carstene1ns closed 4 years ago

carstene1ns commented 8 years ago

How to deal with mp3 support on them (install libmpg123 or not/just use sdl_mixer instead)?

carstene1ns commented 8 years ago

Status update: Currently, users under Debian (+Ubuntu), Fedora and SuSE will not hear MP3 music.

Ghabry commented 8 years ago

I thought Debian distributes this in the non-free repo? For Ubuntu this is maybe really a problem because it has a userbase... But Fedora users should be used to it.

carstene1ns commented 8 years ago

Sorry, what I wrote was not clear, was just meant as a short summary. Currently, we do not use libmpg123 for our OBS builds. That means no mp3 decoder.

Also, as said in #1, the SDL2_mixer build provided by us does not have any external dependencies (libmad), so it does not support MP3. Usually, this is no problem, as the users will download the newer build from multiverse repository under Ubuntu or default repository under Debian. However, when they download our build: no MP3 music.

So I need to differentiate my statement from above: Currently, users under Debian (+Ubuntu) may not and users under Fedora and SuSE will not hear MP3 music.

About using/building libmpg123: This is certainly possible, Ubuntu should provide a package and Debian likely too. Depending on which repository it is in, this would need copying over to the OBS. So it can be used for building the Player there. SuSE and Fedora are a different can of worms, I certainly do not want to deal with their patent policies or void them. However, there are alternative repositories (e.g. PackMan) that also ship mp3 libs. Maybe we can let them add a Player build with MP3 support in there.

fdelapena commented 7 years ago

I guess this issue is not a problem anymore, even Fedora and other already added libmpg123 to their repositories.

carstene1ns commented 7 years ago

I tried enabling it for 0.5.1, however it is not found under Fedora and SuSE. I might add it like the SDL stuff as package only for building for Fedora 25+.

carstene1ns commented 7 years ago

Fedora 26 comes with MP3 support (17d3d09f2adb).

Ghabry commented 4 years ago

Because MP3 patent is gone is this still an issu somewhere?

carstene1ns commented 4 years ago

This is now really better:

Arch: has, used Fedora 28-31, rawhide: has, used xUbuntu 16.04-18.10: has not xUbuntu 19.04-20.04: has, unused Debian 9: has not Debian 10/Testing: has, unused openSUSE Leap 15.0-15.2, Tumbleweed: has, unused

For SUSE it just needs a small .spec update. Debian is a bit more difficult, because the .dsc does not support conditionals.

carstene1ns commented 4 years ago

Tumbleweed still has some problem with mp3, but all others former unused have it now enabled. Edit: Added mp3 support info to README.