Cloning Fix + Various other fixes

Eclipse-Station / NEV-Northern-Light

Congratulations, [employee name here]! You have greatly advanced the expedition effort. You must be the pride of [employee hometown name here]! NanoTrasen commends your usefulness to the Corporation.

https://discord.gg/xuS4t9U

Other

8 stars 54 forks source link

Cloning Fix + Various other fixes #1772

Closed GeneriedJenelle closed 4 months ago

GeneriedJenelle commented 4 months ago

About The Pull Request

This does the following:

Re-adds soul crypts upon roundstart (selected in char modification), as this was removed in upstream Eris
Makes soul crypts compatible with current new DNA system
Fixes cloning, so the process fully works and transfers physical appearance
Character randomization seemed to not be working, this is now rectified.
Removes depricated skin tone feature and replaces it with skin color entirely, species have their own preset skin colors
Added skin color selector (for suggested skin tones) per species, this can be edited by devs/lore when you feel like it.
Humans mobs will no longer spawn as Vox by default.
Various bug fixes.

Why It's Good For The Game

Re-adds a vital feature of the game.

Testing

I've tested the cloning system from start to finish, the vars do appear to transfer successfully.

Changelog

:cl: fix: fixes cloning and crypt data add: adds a character skin color selector add: crypt enable/disable from char menu /:cl:

GeneriedJenelle commented 4 months ago

In order for this PR to pass fully, ensure the Mao gun fix is fixed. That appears to be tripping off the integration tests: https://github.com/Eclipse-Station/NEV-Northern-Light/pull/1771

MciReloaded commented 4 months ago

To be fair, we had the soulcrypt as an option under the augmentations menu. Now, one can spawn with two soulcrypts. Funny happenstance~

GeneriedJenelle commented 4 months ago

To be fair, we had the soulcrypt as an option under the augmentations menu. Now, one can spawn with two soulcrypts. Funny happenstance~

Which option would you like me to keep?

MciReloaded commented 4 months ago

The one in the augmentations menu, please. It's designed to be soul crypt or cruciform, And the augmentations menu is already set up to give that restriction.

On Sun, Jul 21, 2024, 7:30 PM cassy_jenelle @.***> wrote:

To be fair, we had the soulcrypt as an option under the augmentations menu. Now, one can spawn with two soulcrypts. Funny happenstance~

Which option would you like me to keep?

— Reply to this email directly, view it on GitHub https://github.com/Eclipse-Station/NEV-Northern-Light/pull/1772#issuecomment-2241813133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKVWX5LASRBABYSWMQE3SADZNRACDAVCNFSM6AAAAABLGGCBY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRHAYTGMJTGM . You are receiving this because you commented.Message ID: @.***>

GeneriedJenelle commented 4 months ago

The one in the augmentations menu, please. It's designed to be soul crypt or cruciform, And the augmentations menu is already set up to give that restriction.

All done!