EcmaTC53 / spec

Ecma TC53 spec work
23 stars 9 forks source link

Merge Sensor Class proposals into main spec text Section 14 #24

Closed andycarle closed 2 years ago

andycarle commented 2 years ago

This PR takes the Sensor Class proposals that have been discussed and reviewed at recent TC53 committee meetings and merges them into Section 14 of the main spec text.

I would appreciate a review from everyone on the committee that has an interest in the Sensor Class definitions. In particular, the names that I've chosen for various pieces (the Sensor Classes, sample object property names, etc.) all could use some final consideration. Units chosen for sensors are also up very much up for debate until this is finalized.

Tagging a few people that I know may be interested: @rwaldron @dtex @jsiegelmsu @phoddie

phoddie commented 2 years ago

Thanks for pulling this all together. I gave it a quick review and it appears to match what we discussed in committee. I will give it a more detailed review soon.

jsiegelmsu commented 2 years ago

I've taken a look and things look good to me. Thanks for creating the spec text update.

phoddie commented 2 years ago

This looks ready to merge.

I took a few notes that don't need to be addressed immediately: