search

EcoExtreML / zampy

Tool for downloading Land Surface Model input data
https://zampy.readthedocs.io/
Apache License 2.0
1 stars 0 forks source link

Add tests #10

Closed geek-yang closed 1 year ago

geek-yang commented 1 year ago

We add tests to zampy.datasets functions and functions in utils.

geek-yang commented 1 year ago

Note that CD/CI on windows fails due to an unexpected PermissionError. This post seems to provide a solution to fix it (thanks for suggesting it @SarahAlidoost). Still needs to test whether it works or not.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

geek-yang commented 1 year ago

@geek-yang nice work on adding tests 👍 The tests cover most of the codes, well done. 🚀 Thank you for setting up the sonarcloud, too. I left some comments, please let me know if something is unclear. Besides those comments, I am wondering if we can re-organize files e.g. now there is a utils.py file and there is a directory utils. This is confusing. Can utils.py be moved to utils folder?

Thanks a lot for your review @SarahAlidoost. The comments help a lot. I think I have addressed all of them, please take a look again.

Regarding the utils, I totally agree with you 😂. During the development I always open the wrong file or adding the wrong path due to this confusing name. Let's make an issue and change it in another PR.