EddieHubCommunity / RepoRater

Rate GitHub Repos for Developer Experience (DX)
https://repo-rater.eddiehub.org
MIT License
149 stars 37 forks source link

[FEATURE] Remove `Github /` from User Rankings #135

Closed adityaraute closed 1 month ago

adityaraute commented 4 months ago

Is this a unique feature?

Is your feature request related to a problem/unavailable functionality? Please describe.

After navigating to the User Rankings we notice that all users have a prefix GitHub / Since we are using GitHub OAuth, all users will have this title. I don't see the point of having the same prefix for all users. It would make for a much cleaner UI if this prefix is omitted.

Proposed Solution

When displaying that part of the card, we can simply truncate that part of the string, and display just the username, as is done in the Activity feed. (See screenshot below)

Screenshots

User Rankings page: image

Activity Feed image

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this (issue will not be assigned if this is skipped)

NA

Bashamega commented 1 month ago

I would like to work on that. There is a line that i just need to get rid of

eddiejaoude commented 1 month ago

Thank you for raising the issue. I would like to keep the prepended github, this was done as part of the design, because in the future we may have other sign in options. So i will close this issue for now

github-actions[bot] commented 1 month ago

Thank you all for contributing to RepoRater! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give the repo a star ⭐