EddieHubCommunity / support

Community Help & Support and AEA (Ask Everyone Anything)

https://eddiehubcommunity.github.io/support/

MIT License

342 stars 159 forks source link

[REVIEW] Portfolio #2995

Closed avneesh0612 closed 2 years ago

avneesh0612 commented 3 years ago

Portfolio link

https://www.avneesh.tech/

github-actions[bot] commented 3 years ago

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

gptkrsh commented 3 years ago

Add an image or something in the right section of the hero
A hover animation that turns the testimonial cards back to normal (not-diagonal) would be a nice addition
A profile pic for the testimonial authors and link to their profile or something?

I do not know much about portfolios since I do not have one, so sorry I can't say any more 😅

avneesh0612 commented 3 years ago

Those are some great ideas, thanks! Idk what can I do with the first point but will definitely implement the 2nd and 3rd 💯

hellodeborahuk commented 3 years ago

It looks great! You could move your photo up to the hero section? This would also remove the empty white space where the image is pushing down the skills section.

It depends who your target audience is but I'd change the order. If it's recruiters I'd move projects up and about me & testimonials down. You want them to see the most important things first. If you want to get clients, then testimonials is good at the top, I think they'd still want to see what you've done though so moving the projects up again.

There's a space missing in the hero after full stack developer.

I'd also consider a form for contact.

I love the animation you've got going on.

avneesh0612 commented 3 years ago

Hey, @hellodeborahuk I will move the image up. And I don't really have a targetted audience right now but I will move the projects up yeah.

I didn't add a contact form because it is mostly just spam. So I just added ways to contact me. Thanks :D

avneesh0612 commented 3 years ago

So how is this order-

About
Testimonials
Work
Skills
Contact

avneesh0612 commented 3 years ago

Hey, I have added some changes. Any other feedback is welcome :) https://www.avneesh.tech/

EmmaDawsonDev commented 3 years ago

Looks great! Just a couple of things I noticed:

you’ve got some sideways glide on mobile/iPad because of the projects section
Everything else is left aligned but the contact section is center aligned and it is slightly jarring to the eye
Don’t downplay your skills by saying that you’re a school kid in your intro, I’d suggest taking it out.

avneesh0612 commented 3 years ago

Ahem, nice suggestions. Thanks @emmalearnscode

helper-uttam commented 3 years ago

@avneesh0612 I loved your portfolio! How about adding some transition delay to the button: hover effect?

avneesh0612 commented 3 years ago

Hey @helper-uttam thanksm which button are you talking about?

avneesh0612 commented 3 years ago

Btw, here is the repository- https://github.com/avneesh0612/portfolio-template

eddiejaoude commented 2 years ago

Reviewed on live stream https://youtu.be/i2t50B5lmIU

Looks good, some thoughts

have releases
use github actions for: build, lint, releases, deploy
maybe add automated e2e testing

avneesh0612 commented 2 years ago

Thanks for reviewing, added releases, and GitHub actions! Have created an issue for e2e testing, if it stays open for sometime I will learn about testing and implement it :)