EdgeTX / buddy

The next generation tool for EdgeTX. A cross platform app, with browser compatibility.
https://buddy.edgetx.org
MIT License
37 stars 19 forks source link

small corrections to DA #70

Closed HThuren closed 8 months ago

HThuren commented 8 months ago

? where to find 'dansk' in language selector at web, have to be 'Dansk'

and Bump iso-639-1 from 2.1.11 to 3.1.1

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (99d2c90) 51.18% compared to head (f24ec2a) 51.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #70 +/- ## ======================================= Coverage 51.18% 51.18% ======================================= Files 89 89 Lines 9015 9015 Branches 685 685 ======================================= Hits 4614 4614 Misses 4392 4392 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

freshollie commented 8 months ago

The language names come from this package: https://github.com/meikidd/iso-639-1/blob/master/src/data.js#L122

If it should be captalized in the native language you could submit a PR there and update the library here :)

HThuren commented 8 months ago

The language names come from this package: https://github.com/meikidd/iso-639-1/blob/master/src/data.js#L122

If it should be captalized in the native language you could submit a PR there and update the library here :)

Thank you, I have maked a PR for the correction :-)

HThuren commented 8 months ago

@freshollie ... and the PR are merged by meikidd :-)

HThuren commented 8 months ago

@freshollie package.json are reported not to be part of git, can you fix that ? image

HThuren commented 8 months ago

@freshollie anyway, please approved this PR, have some small correction to #69

freshollie commented 8 months ago

If you commit with -n you can ignore the error. Please include the library upgrade as part of this

HThuren commented 8 months ago

If you commit with -n you can ignore the error. Please include the library upgrade as part of this

YES ! thank you :-)

HThuren commented 8 months ago

(sorry mixed different branch when make another PR) Now ready here both DA correction and Bump of iso639-1