search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.63k stars 345 forks source link

Enabling both internal and external ELRS should be usable or impossible #4937

Open wimalopaan opened 7 months ago

wimalopaan commented 7 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Oviously ETX is not designed to use two ELRS modules anabled at the same time. Telemetry -> "Start search sensors" completely hangs the radio (need to disconnect the battery).

Expected Behavior

It is possible to physically have two ELRS modules in one radio: internal and external.

Either:

a) If one of the modules is enabled, keep the other disabled

b) allow that both are enabled, and then use them in the expected behaviour. This includes telemetry (EdgeTx then has to process two telemetry streams) and the elrsV3.lua, which needs to choose between the two.

Steps To Reproduce

1) Enable both modules for a specific model 2) In "Telemetry" start "Search sensors" 3) the radio freezes.

Version

Other (Please specify below)

Transmitter

FrSky X12

Operating System (OS)

Linux

OS Version

Arch Linux

Anything else?

No response

pfeerick commented 7 months ago

Didn't know it would make it crash, but unexpected/indeterminate behaviour was expected, but is probably only documented deep in some telemetry related issues where telemetry needs to be overhauled to allow for seperate streams for multiple modules. Disabling both is not really an option even know, as you can use both (i.e. for dual independent Rx , or dual frequency), just can't manage telemetry or Lua with both connected at the same time. Similar to using multiple rxs with a single tx for extra channels, maybe disabling telemetry on second tx/rx pipelinemay help here.

wimalopaan commented 7 months ago

Updating the internal and the external ELRS module to 3.3.4-RCx fixed the freeze problem.

raphaelcoeffic commented 7 months ago

It shouldn't be missing much, as most things are already separate.

wimalopaan commented 7 months ago

Well, I don't know, what the problems with the actual implementation is, so I can't imagine to nearby solution. I do not even know for sure if this is also true for the MPM.