Open icebreaker-ch opened 3 days ago
Unsure what your issue actually is. I did setup a wired trainer, and as you can see, multiplier does indeed affect values
And here the same pictures for my wireless Trainer setup:
Ok so a wireless trainer specific issue. Is that multi trainer ?
I can confirm, that it works in a wired trainer setup, but not in my wireless setup. I used the following combination: Trainer: Radiomaster Zorro 4in1 with a IRangeX IRX4 LITE Multi Protocol Module. Student: Radiomaster T8 Lite.
In the current code, the value set in this multiplier field is called "PPM_Multiplier" and is applied only to DSC (training wire) port. So it does not apply to wireless, SBUS or any other trainer methods. So
1) we can change the UI to only display this multiplier when DSC input is selected (and use mixer weight if you want to adjust it, which would make sense since you probably don't want the same weight for all control surfaces)
2) we change the code so it is applied for all forms of trainer (at teh risk of breaking existing setup)
I leave it to you, how to solve this issue. Both variants are acceptable to me, because the use case I had (reducing the weight of the students input) can be achieved by setting the weights of the involved channels as well. To have this in a single setting would have been just a convenience and probably is some kind of abuse of the multiplier factor either.
Is there an existing issue for this problem?
What part of EdgeTX is the focus of this bug?
Transmitter firmware
Current Behavior
Multiplier setting in Trainer Settings has no effect. The documentation says: Multiplier - This value changes the weight of all the sticks together. But regardless of the value set for Multiplier, the weight of the sticks is the same.
Expected Behavior
I expected, to set multiplier for example to 0.5 and the input of the students transmitter weights only by 50%
Steps To Reproduce
Version
2.10.5
Transmitter
RadioMaster Zorro
Operating System (OS)
No response
OS Version
No response
Anything else?
No response