Edgio / vflow

Enterprise Network Flow Collector (IPFIX, sFlow, Netflow)
http://www.verizonmedia.com
Apache License 2.0
1.08k stars 224 forks source link

Errors in trying to use this project as a library #161

Closed ishanjain28 closed 2 years ago

ishanjain28 commented 2 years ago

Last release was 0.9.0 back in 2020.

At that point in time, The go.mod in this project referred to this project as,github.com/VerizonDigital/vflow. See

Go tooling tries to pull the latest tag which is 0.9.0 and then fails because it's trying to download github.com/EdgeCast/vflow but the project in that tag is still called, github.com/VerizonDigital/vflow.

emerald :: ~/hobby/netflow.test 130 » go get -u github.com/EdgeCast/vflow/vflow
go: github.com/EdgeCast/vflow@v0.9.0: parsing go.mod:
    module declares its path as: github.com/VerizonDigital/vflow
            but was required as: github.com/EdgeCast/vflow

Please create a new release. The project name in go.mod has been updated already so a new release should fix the problem.

tinselcity commented 2 years ago

@ishanjain28 The project's original maintainer @mehrdadrad has moved on to another company (Riot Games I believe).

I'm not sure how much he's planning on maintaining it going forward. I'm not entirely familiar with the project or the release process, but I'll try to give the project an org update and a new release.

ishanjain28 commented 2 years ago

hey @tinselcity thank you for responding!

I had tested this out in my own fork https://github.com/ishanjain28/vflow and just creating a new release will fix this problem.

(also, I had to write my own thing for this because this project doesn't support dumping flows to ZMQ which is used by ntopng)

tinselcity commented 2 years ago

Thx I put up PR: https://github.com/EdgeCast/vflow/pull/162 I'm reaching out to Mehrdad as well. I'll try to at least get some module updates and maybe a latest release out the door.

Thanks so much for bringing this to our attention!

mehrdadrad commented 2 years ago

Thanks @tinselcity! I just merged the PR and I created a new release! (v0.9.1) @ishanjain28 Please try again!

tinselcity commented 2 years ago

Thx so much @mehrdadrad !

ishanjain28 commented 2 years ago

It works fine now! thank you