EdwardHinkle / remark

A fun social reader for iOS/macOS using IndieWeb technology
https://eddiehinkle.com/2019/05/08/5/article/
MIT License
9 stars 0 forks source link

Support display of quoted Tweet replies #64

Open skpy opened 6 years ago

skpy commented 6 years ago

I reported the same issue on XRay: quoted reply tweets aren't showing the quoted content in Indigenous.

This tweet: https://twitter.com/miklb/status/1015014506651668480

shows up like this in Indigenous: indigenous-ios-quoted-reply

And this is the HTML that Granary is generating:

<article class="h-entry">
  <span class="p-uid">tag:twitter.com:1015014506651668480</span>

  <time class="dt-published" datetime="2018-07-05T23:28:11+00:00">2018-07-05T23:28:11+00:00</time>

  <span class="p-author h-card">
    <data class="p-uid" value="tag:twitter.com:miklb"></data>
<data class="p-numeric-id" value="6187652"></data>
    <a class="p-name u-url" href="https://miklb.com">Michael Bishop</a>
    <span class="p-nickname">miklb</span>
    <img class="u-photo" src="https://pbs.twimg.com/profile_images/799821749386874880/X_vv7MnK.jpg" alt="" />
  </span>

  <a class="u-url" href="https://twitter.com/miklb/status/1015014506651668480">https://twitter.com/miklb/status/1015014506651668480</a>
  <div class="e-content p-name">

  I’m so making this into a t-shirt
  </div>

<article class="u-quotation-of h-cite">
  <span class="p-uid">tag:twitter.com:1015005409726357504</span>

  <time class="dt-published" datetime="2018-07-05T22:52:02+00:00">2018-07-05T22:52:02+00:00</time>

  <span class="p-author h-card">
    <data class="p-uid" value="tag:twitter.com:gitlost"></data>
<data class="p-numeric-id" value="1240421984"></data>
    <a class="p-name u-url" href="https://twitter.com/gitlost">Developers Swearing</a>
    <span class="p-nickname">gitlost</span>
    <img class="u-photo" src="https://pbs.twimg.com/profile_images/3336578378/a60d4b744784d4ab05ee1846234e0708.jpeg" alt="" />
  </span>

  <a class="u-url" href="https://twitter.com/gitlost/status/1015005409726357504">https://twitter.com/gitlost/status/1015005409726357504</a>
  <div class="e-content p-name">

  Still can't git fer shit
  </div>

</article>
EdwardHinkle commented 6 years ago

Great, thanks! This is definitely something I want to improve with the timeline display.

aaronpk commented 6 years ago

Once I add the quoted tweet info to the XRay response, it's going to require clients to recognize the property and render the additional content. Do you have an idea of what you want that to look like? My plan was to make the quotation-of property a nested h-entry just like the main one.

EdwardHinkle commented 6 years ago

Yep, @aaronpk my goal would be to be able to just nest a “post” view within the existing view, and pass it an h-entry