search

EdwardPiwowar / BBA

2 stars 0 forks source link

Regression testing #563

Open ThorvaldAagaard opened 4 months ago

ThorvaldAagaard commented 4 months ago

I think it is good idea to have a set of boards bid by BBA, that you rebid before releasing a new version.

So basically you bid the hands and save it in BEN format

Now for next release you bid the same hands and compare the bidding with the previous version.

Depending on the change only a few sequences should be change, and you can verify it is the expected change.

If suddenly many sequences are changed, then an error might have been introduced.

It should not be needed to check every change, but just to get an impression, that all is OK

Now, thinking about this a better idea could be to be able to load a BEN-file into BBA, and let BBA compare the bidding from the file with how BBA would bid it now (It could even read the name of the .bssa file)

Then BBA could show the 2 biddings, and the user could validate the code is working as designed.

Today I have to bid all the hands using BBA and the use compare, and I am more interested in some instant feedback, so the third option could be a script outside BBA, like the EPBot-dll, but that would require a more consistent update of the DLL

EdwardPiwowar commented 4 months ago

In the first part you described one of my testing methods. I generate subsequent dll libraries and compile them with the BBA dedicated to this library. This requires registration of libraries, which is why I do not publish them. But for testers, it could be a good option.

ThorvaldAagaard commented 4 months ago

Comparing the latest version with an older version gave me this image

So a deal like this ia wrong in latest version, but many changes in just a small set of deals image

EdwardPiwowar commented 4 months ago

Is the contract bad or can it be bad?

ThorvaldAagaard commented 4 months ago

When the bidding goes 1H-P-1S-X XX-P-P-P someone done something stupid, and I did not look who it was

Looking at the deal I think it is both East and West

image

Pass with just 4 Spades is wrong - 1N is a fine bid. Wests Pass also seems wrong

After the opponents open the should never de left double (or redoubled) at the one-level in what looks like an 8-card fit.