Some fixes, Tweaks and Charpter 13 support

Egoistically / ALAuto

Azur Lane bot based on azurlane-auto. Discord: https://discord.gg/vCFxDen.

Do What The F*ck You Want To Public License

106 stars 43 forks source link

Some fixes, Tweaks and Charpter 13 support #71

Closed MetalDevOps closed 4 years ago

MetalDevOps commented 4 years ago

Refactored and simplified a few lines of code.
Fix stuck problem when monthly login message appears,
Add charpter 13 support
Swipe optimization of some maps like 11-3, 12-2, 12-3, 13-1, 13-2, 13-3, 13-4. In my tests, I was able to farm them smoothly, however it needs a lot of testing to be sure because of the RNG.
New button_confirm asset.

Al12rs commented 4 years ago

Hey, thanks for your PR. I have some questions and feedback regarding your changes though.

First it would be better if this kind of PR didn't contain formatting changes as those are subjective and a project could have specific policies about them. It makes it more difficult to identify the actual changes that were made to achieve the implemented feature. They basically add clutter and are unrelated so they should be submitted as a separate PR if needed.

Now regarding your actual changes I will make some comments directly under the code

MetalDevOps commented 4 years ago

Hey, thanks for your PR. I have some questions and feedback regarding your changes though.

First it would be better if this kind of PR didn't contain formatting changes as those are subjective and a project could have specific policies about them. It makes it more difficult to identify the actual changes that were made to achieve the implemented feature. They basically add clutter and are unrelated so they should be submitted as a separate PR if needed.

Now regarding your actual changes I will make some comments directly under the code

Sure, I understand your point, I've been studying python for quite some time now, and since I'm learning now I'm trying to follow the documentation faithfully.

Thanks for the feedback.

Egoistically commented 4 years ago

First time I write a PR review. I apparently didn't quote some parts of the code properly, but I think you can understand what I mean. Let me know if you don't understand something.

MetalDevOps commented 4 years ago

First time I write a PR review. I apparently didn't quote some parts of the code properly, but I think you can understand what I mean. Let me know if you don't understand something.

Thanks for feedback, i' will do some fixes.