search

ElDewrito / ElDorito

A Halo Online modification
725 stars 142 forks source link

Allows discord rich presence password string to be updated while serv… #468

Closed ThunderWaffle closed 6 years ago

ThunderWaffle commented 6 years ago

…er is online.

Proposed changes in this pull request:

  1. Allows a host to change the password while the server is online without breaking discord rich presence joins.

Why should this pull request be merged?

Right now if you change the server password when already set to online, the Discord rich presence links are not updated with the new password. This breaks joining through rich presence.

Have you tested this on your own and/or in a game with other people?

Tested in game with 2 other folks.

Test steps

  1. Set a password and then start server.
  2. Have players join then leave through a discord invite.
  3. Change password but keep server on.
  4. Have them attempt to rejoin with same discord invite.
ThunderWaffle commented 6 years ago

There are some possible problems I've introduced elsewhere. Going to close and re-evaluate. I'll make a new request if/when I feel comfortable.