ElbowBaggins / GinsorAudioTool2Plus

Ginsor's Audio Tool 2 for Destiny, now open and improved!
GNU General Public License v3.0
37 stars 7 forks source link

Still broken and DCV is about to consume more #9

Closed RumekFuria closed 3 years ago

RumekFuria commented 3 years ago

ok look m8. yes I shoudn't be making this issue since the other one exists but I have to at least get some answer in some way. you said it yourself. "A minor fix" yet an entire season and a half has passed, still broken. DCV is happening, half of Forsaken is being removed. this is the only tool of this kind that would allow people to easily archive sound files before they dissapear forever

all I ask for is any kind of answer. of course I hope the answer will be "yes yes fixing it" but I at least want to know should I just wait, or start seeking places to fix it myself/have someone else fix it. at least leave some compilation instructions in the readme for anyone wanting to dabble in this mess themselves

ElbowBaggins commented 3 years ago

If you want to compile it yourself you just need the latest Visual Studio Community edition and the contents of the repo. If you open up the SLN file it should set up the whole project for you and you'll just be ready to go. It's not in the readme because it's pretty much plug-and-play if you have VS installed.

That said, it would be a minor fix if the files had not changed in the way they have. The file locations that once held the relationship between the voice line audio, their narrator, and the related text has been zeroed out seemingly by Bungie themselves. I'm not the only one looking at this particular change and we haven't really come up with a consensus on where this data "went". My personal belief is that these relationships have been baked into the game executable in order to save themselves the lookup steps. If this is true, and it would seem to be as the "old" data doesn't seem to appear anywhere in the package structure anymore, then there is simply no way to "fix" it in the way the community would like. I suspect this change was made to improve performance and load times in the game. This change follows other changes to the package format itself, which has been in a state of considerable flux since the Activision separation, presumably in the name of making the improvements their engine does very much need.

That said, not all is lost. Destiny 2's "package" system is basically a virtual file system spread across multiple shards/packages. Each ,pkg file contains entries (which refer to a specific file) and blocks (the raw data for said file). Entries specify which blocks make up that entry's file. Only the virtual file that once contained the relationship data appears to be "lost". (It actually appears to be present-but-empty, I assume it will be culled in Witch Queen) The part of the code that actually handles the extraction of audio and text files is still working. As such, it is possible to repurpose this stuff to do a bulk dump of all text and audio files within the package system. You would then have to relate the text to the audio yourself in some way if you wanted to do that, which I understand is a large task but that's where we're at. This may be sufficient for bulk-archival purposes though.

Also, if you have a way of getting ahold of a Destiny 2 fileset from before Season of the Splicer, those files will work with the current release version and that might be your best best for collecting stuff from Forsaken.

If myself or anyone else discovers that this relationship data has just moved to a new home, the segment of code that handles it is simple enough to modify to look elsewhere. At that (completely hypothetical) point, it would become possible to fix this tool, but not until then.

So, tl;dr - Yes, it is a "minor fix" from the standpoint that any code modification required to fix this will likely be minor. Unfortunately, it appears Bungie has entirely removed the relationship data that is the secret sauce this tool needs to work. It's still fully possible to hack up its innards to do a bulk dump, but unless this relationship data can be re-found elsewhere (and I'm not the only one looking) then we are, quite disappointingly, at the end of the road. If this discovery occurs, then you can count on that fix making its way here, but you are probably in for the same indefinite wait that I am.

Sorry.

RumekFuria commented 3 years ago

thanks for the fast reply. I kinda guessed that maybe things just went very sideways for the minor fix to take so long, and nice to know what the exact issue is (even if I don't actually have much idea about things but I have a talent to vaugely understanding anything)

and yes I suppose if I somehow "rolled back" the update back to season of the choosen state, one could still use the tool as is, and that would be sufficient. now how to do it tho is another story. no idea if steam's "download older version of game" would work with D2, but one can hope. I mean I don't even have to run the game as long as I can download something

well I guess I will close this now, post the link in the other one so people can know too Again, thanks for fast reply, and in this case, don't sweat it. Datamining do be like that sometimes I guess good luck to ya lot

ElbowBaggins commented 2 years ago

Duplicate of #7