search

Election-Tech-Initiative / electionguard-core2

Core codebase of ElectionGuard 2.0
MIT License
12 stars 9 forks source link

✨ Review Test_Multiple_Submit() #38

Closed john-s-morgan closed 2 years ago

john-s-morgan commented 2 years ago

Is there an existing issue for this?

Suggestion

Look into bindings/netstandard/ElectionGuard/ElectionGuard.Encryption.Tests/TestEncrypt.cs's Test_Multiple_Submit() method. Specifically to understand the goal of what we are testing.

Also refactor for loop to use something more modern

Possible Implementation

for loop option:

Enumerable.Range(1,10000).ForEach(using new SubmittedBallot(ciphertext, BallotBoxState.Cast));

Anything else?

No response

john-s-morgan commented 2 years ago

The purpose was to catch memory leaks that have occured in this area in the past.