🐞 Fix Schema for votes_allowed and number_elected

Election-Tech-Initiative / electionguard

ElectionGuard is a set of open source software components that can be used to create and publish end to end verifiable elections as well create a publishable artifact for ballot comparison audits.

https://www.electionguard.vote/

MIT License

828 stars 130 forks source link

🐞 Fix Schema for votes_allowed and number_elected #291

Closed lprichar closed 2 years ago

lprichar commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

votes_allowed can be null or zero

Expected Behavior

votes_allowed must be an integer, non-null and greater than 0 number_elected must be an integer, greater than 0

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response

abxhr commented 2 years ago

@lprichar I would love to work on this issue 🚀

lprichar commented 2 years ago

@abxhr Awesome, thanks! Just for clarity this ticket is discussing: https://github.com/microsoft/electionguard/blob/main/data/1.0.0-preview-1/schema/manifest.schema.json#L407 and https://github.com/microsoft/electionguard/blob/main/data/1.0.0-preview-1/schema/manifest.schema.json#L403. Is there anything I can help clarify?