Electroblob77 / Wizardry

Source code for Electroblob's Wizardry, a Minecraft mod about magic, exploration and adventure. Open-source so other aspiring wizards (a.k.a. programmers 😎) can see the real magic! ✨ Just want to download and play? Head over to the CurseForge page via the link below:
https://minecraft.curseforge.com/projects/electroblobs-wizardry
Other
202 stars 106 forks source link

Increase configuration options for modpack customisation and other customisation options. #92

Closed Needmoremods closed 5 years ago

Needmoremods commented 5 years ago

Minecraft version: 1.10.2 [change as necessary]
Wizardry version: Electroblob's+Wizardry+-+2.1.2+-+MC+1.10.2 [change as necessary]
Environment: Singleplayer

Issue details: Just a few possible suggestions.

Config:

Other

Electroblob77 commented 5 years ago

Thanks for the suggestions!

Far from instantly killing mobs, ice age and ice statue do not deal any damage whatsoever, they simply freeze the target for a certain period of time. I am aware that this sometimes disrupts boss mechanics so in future boss mobs will probably be immune to these spells.

Yes, you can change the castCommandMultiplierLimit in the config file. More on that here.

Customisation and configurability in general is something I'm working on. In particular, a lot of people have requested being able to adjust individual spell attributes, so these will be defined in JSON files allowing them to be changed with a resource pack.

Blast upgrades increase the radius of quite a few spells, including blizzard. I'm extending this to more spells for the next update.

I'm reluctant to add four tiers of armour simply because it would generate a lot of items, but I do want to expand what can be done with wizard armour.

It would be quite nice and potentially feasible to allow AM2 spells to be cast with wizardry wands, but AM2 isn't in 1.12 yet and it would be a low priority in any case.

Needmoremods commented 5 years ago

Appreciate the feedback.

Far from instantly killing mobs, ice age and ice statue do not deal any damage whatsoever, they simply freeze the target for a certain period of time

Ah I should be more specific. It seems that vanilla mobs and most modded mobs such as those from Lycanite mobs do not die and work as intended. I've tested and isolated it to mobs created with the custom NPC mod where they are instantly killed. As it is isolated to this mod unlikely to be on your end I think. I have notified Noppes to see if it can be fixed.

Yes, you can change the castCommandMultiplierLimit in the config file. More on that here.

Right, but is that only for commands or also for wand casted spells? I can't seem to put the modifier for that above 20. 255 makes sense for the castCommandMultiplierLimit though. What modifier affects summoned creatures damage? Also a suggestion that maybe health could be modifiable with damage for them.

I'm reluctant to add four tiers of armour simply because it would generate a lot of items, but I do want to expand what can be done with wizard armour.

Understood, clutter indeed.

It would be quite nice and potentially feasible to allow AM2 spells to be cast with wizardry wands, but AM2 isn't in 1.12 yet and it would be a low priority in any case.

Only but a wish away, unfortunately AM2 development seems stagnated among the various bugs it still has, maybe one day :').

Electroblob77 commented 5 years ago

Right, fair enough about custom NPCs. Feel free to post an issue here anyway, it's good to keep track of things.

The modifier limit is only for commands, yes. The wand ones are fixed anyway though, not sure how you could be changing that at all. Summoned creatures are currently not affected by damage modifiers. However, this will be changing! I need to decide whether to make them deal more damage, have more health, or a bit of both, but one of those will happen.

Needmoremods commented 5 years ago

The modifier limit is only for commands, yes. The wand ones are fixed anyway though, not sure how you could be changing that at all.

I have been changing the player attribute via the following config option:

Global damage scaling factor for the damage dealt by players casting spells, relative to 1.
    D:playerDamageScaling=20.0

Where I am unable to increase the scaling above 20.

I am hitting something like 500 damage (250 hearts I think) with lightning disc each cast when maxed out in potency etc. Thus I assumed that such damage would be attributed to the modded attribute, however if I remember correctly, it did increase the damage I have dealt.

I need to decide whether to make them deal more damage, have more health, or a bit of both, but one of those will happen

I guess maximal customisation would be something like, change a multiplier for health or damage to scale accordingly to however one would want.

Though I have to say, one of the best magic mods I've ever played on Minecraft. Clean and smooth. Well done to you.

Electroblob77 commented 5 years ago

Oh, you're scaling it with that config option, I see. That's a limit set in the code, you have to set a min and a max so 20 must be what I chose at the time. That config option was intended as a quick way to adjust balance for different sizes of modpack, pvp or whatever, so I figured 20 was more than enough. I can easily change it if people want.

And thanks!

Electroblob77 commented 5 years ago

The limit has been increased to Integer.MAX_VALUE (2^31-1) in the 4.2.0 release.