Element-Research / rnn

Recurrent Neural Network library for Torch7's nn
BSD 3-Clause "New" or "Revised" License
938 stars 314 forks source link

Assigning "maxnormout" to LookUpTable #391

Closed tastyminerals closed 7 years ago

tastyminerals commented 7 years ago

In recurrent lm example on line 76, I noticed the following line lookup.maxnormout = -1 -- prevents weird maxnormout behaviour. Maybe I misunderstand but shouldn't it be lookup.maxNorm = -1 since nn.LookupTable does not have maxnormout field but has maxNorm. I searched through LookupTable source history and didn't find any mentions of maxnormout. How this field is getting registered in the model?

tastyminerals commented 7 years ago

created a pull request