Composer intergration - Githubissues

Wouter0100 commented 8 years ago

Are people interested in this? While talking with @gerard-kanters about the stap where composer-plugins have to manually submit new versions to the Elgg-plugin store, we thought maybe it would be nice to have an intergration with github/bitbucket and Composer.

It could be implemented like:

Selection box in plugin settings if it's a composer plugin (recommended) or a manually released plugin.
When manually is selected, the old system is still used.
When composer is selected, the version history will be received from packagist.org.
- The zips/tar's could be disabled (or received from git, but that is extra work)
- When you click the download button, maybe a prompt appears with something in it like composer require {plugin_name} {version}, so you're simple able to copy-paste it.
- Reload of the history (and update) could happen when a webhook is configured in Github/Bitbucket, on this way the recently updated still works (instead get latest version every page load, or something).

beck24 commented 8 years ago

Yeah we've been talking about git integration on and off for a few years now, just nobody has pulled the trigger to get something fully production ready. There's interest though as the current method is pretty dated.

Wouter0100 commented 8 years ago

Awesome, in that case I'll take a look in the next couple of days to integrate this :+1:

mrclay commented 8 years ago

Sounds good. @hypeJunction Any input here?

hypeJunction commented 8 years ago

Check in with Jeroen @jdalsem. He started working on something. I wrote down some thoughts in another ticket. Will find it later. On Mar 11, 2016 10:16 PM, "Steve Clay" notifications@github.com wrote:

Sounds good. @hypeJunction https://github.com/hypeJunction Any input here?

— Reply to this email directly or view it on GitHub https://github.com/Elgg/community_plugins/issues/137#issuecomment-195556853 .

gerard-kanters commented 8 years ago

I am off course in full support of this. The benefit is that a dev only needs to update the gitb repo and do not need to update the community repo anymore. Zip files can still be available because git has that function anyway, from a user perspective it will be a bit off a hassle, since git adds the branch name to the the zip file . We might be able to overcome this.

While relying more and more on github and composer, it seems like the only logical way.

hypeJunction commented 8 years ago

I don't think tying to branches will work. We should check for an actual github release (or possibly a tag). On Mar 11, 2016 11:33 PM, "Gerard Kanters" notifications@github.com wrote:

I am off course in full support of this. The benefit is that a dev only needs to update the gitb repo and do not need to update the community repo anymore. Zip files can still be available because git has that function anyway, from a user perspective it will be a bit off a hassle, since git adds the branch name to the the zip file . We might be able to overcome this.

While relying more and more on github and composer, it seems like the only logical way.

— Reply to this email directly or view it on GitHub https://github.com/Elgg/community_plugins/issues/137#issuecomment-195584630 .

hypeJunction commented 8 years ago

The main challenge is specifying what Elgg versions are supported by individual plugin releases. I imagine we have to add custom data to composer or manifest and parse it. I think we need to add a github integration that will push webhooks to the community, not sure reverse integration will work without cron/manual trigger unless we integrate with github API and query Github on each page request. I think we should ask Paweł for his thoughts on this, his composer installer was quite comprehensive and may easily integrate with community plugins. On Mar 12, 2016 1:45 AM, "Ismayil Khayredinov" info@hypejunction.com wrote:

I don't think tying to branches will work. We should check for an actual github release (or possibly a tag). On Mar 11, 2016 11:33 PM, "Gerard Kanters" notifications@github.com wrote:

I am off course in full support of this. The benefit is that a dev only needs to update the gitb repo and do not need to update the community repo anymore. Zip files can still be available because git has that function anyway, from a user perspective it will be a bit off a hassle, since git adds the branch name to the the zip file . We might be able to overcome this.

While relying more and more on github and composer, it seems like the only logical way.

— Reply to this email directly or view it on GitHub https://github.com/Elgg/community_plugins/issues/137#issuecomment-195584630 .

hypeJunction commented 8 years ago

https://github.com/Elgg/community_plugins/issues/134

hypeJunction commented 8 years ago

PR #140

jeabakker commented 6 years ago

closing because of dub #134

Elgg / community_plugins

Composer intergration #137