Ellpeck / ActuallyAdditions

A Minecraft Mod about lots of useful gadgets and things!
http://minecraft.curseforge.com/projects/actually-additions
MIT License
214 stars 99 forks source link

iris compat #1437

Closed Caffeinew closed 2 weeks ago

Caffeinew commented 2 weeks ago

I basically just threw stuff at rendering code untill something worked. Looks like iris doesn't like lightmaps in shaders, so i'm just emulating a similar look with alpha.

Alternatively different render code can be used when iris is active

Also, I think with some changes the atomic thingie laser can use the basic laser rendering fn instead of particle one, but that's like actual work, so I cba.

before:

2024-11-05_05 09 15

2024-11-05_05 09 25

after: 2024-11-05_04 36 27 2024-11-05_04 36 19

Mrbysco commented 2 weeks ago

While testing myself I noticed that while it didn't like the lightmap shader it did accept the tex lightmap one

Caffeinew commented 2 weeks ago

While testing myself I noticed that while it didn't like the lightmap shader it did accept the tex lightmap one

Neither getPositionColorLightmapShader or getPositionColorTexLightmapShader work for me for particle render for atomic laser.

POSITION_COLOR_LIGHTMAP does work for the other ones tho

Mrbysco commented 2 weeks ago

In my testing I had to change the vertex of the ParticleRenderType in the ParticleBeam class away from Particle

A wip video showing it somewhat working in my testing but not fully as it seemed to stop 4,5 blocks outwards

https://github.com/user-attachments/assets/ed4055c8-c1c0-49a6-8d9b-3df996c6e81a

Mrbysco commented 2 weeks ago

But your lasers look better than my lasers did during my attempts

Mrbysco commented 2 weeks ago

The color being wrong is probably an AA bug but might as well fix it if possible ;)

Nevrai commented 1 week ago

Wonderful! As someone who can’t even look at this game without shaders, I really appreciate this.