Emersont1 / itchio

https://pypi.org/project/itchiodl/
MIT License
105 stars 17 forks source link

Add Games in bundle to library does not work #54

Closed GhostJumper closed 1 year ago

GhostJumper commented 2 years ago
root@ca48796d249d:/# itch-load-bundle
Username: my@mail.com
Password:
Bundle URL: http://itch.io/bundle/download/4T80AvOSA70gkpyUhMNhaaghCbEY7J0DAJjWaWZd
Traceback (most recent call last):
  File "/usr/local/bin/itch-load-bundle", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/itchiodl/bundle_tool/__main__.py", line 13, in main
    b.load_games()
  File "/usr/local/lib/python3.10/site-packages/itchiodl/bundle.py", line 17, in load_games
    pages = int(s.select("span.pager_label a")[-1].text)
IndexError: list index out of range
root@ca48796d249d:/#

Did I use the Program as intended, or is this actually an issue?

Emersont1 commented 2 years ago

It works as intended on my machine, are you running this on a datacenter IP (either a VPS or VPN) as I think it likes to block people when they do that

GhostJumper commented 2 years ago

It's running on the official python docker image on my local machine without any vpn.

Emersont1 commented 2 years ago

That's weird, can you try in a venv, just as there may be weird docker shenangins going on.

https://docs.python.org/3/library/venv.html

GhostJumper commented 2 years ago

I tried it inside the official python docker with a venv. Same issue. I'll try it in a vm next.

GhostJumper commented 2 years ago

The outcome of running it on my Manjaro Laptop:

Capture

The issue seems to not be caused by Docker after all.

Emersont1 commented 2 years ago

it works on the latest version on my machine. how many pages is the bundle page?

GhostJumper commented 2 years ago

It has 34 pages (998 items)

Emersont1 commented 2 years ago

can you manually check the class names in your browser, as my only thought is it could be an i18n issue or similar