EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Bug in url query parameters results in 404 when clearing all filters #237

Closed ah-net closed 2 years ago

ah-net commented 2 years ago

Issue Brief

There is a bug in the function getCurrentQueryUrl what results in an 404 when clearing all filters

Environment

Steps to reproduce

  1. Use the following settings in Stores->Configuration->catalog->tweakwise->Layered navigation
    • Enabled, Yes
    • Use default magento filter renderer, No
    • Ajax filtering, Yes
    • Filter form, No
    • Filter url query arguments, Dont filter
    • URL strategy to 'Query params(?color=Red&size=M)'
  2. Clear magento cache
  3. Go to a specific category within your catalog (/women/tops-women/jackets-women.html)4.
  4. Activate an filter with multiple select values (/women/tops-women/jackets-women.html/women/tops-women/jackets-women.html?ae-price%5B0%5D=56.25)5.
  5. Click on 'clear all' in the filterbar to remove all filters

Actual result

/women%2ftops-women%2fjackets-women.html (404 page)

Expected result

/women/tops-women/jackets-women.html

Sensitive logs -- Sensitive logs can be encrypted with our PGP public key using a tool like https://sela.io/pgp/.

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: OpenPGP v2.0.8

xsFNBFj3FS0BEACnqV0NQvwseDQTI8OwYvNhblPdohejds+OcNuSO+czI9Yxm7A5
PA8pSnukJEwB963+za6hBiw5rlDLQyAc887i7oO8tFk3OSI7ac/nOGBcCoEDEKTp
dd43Nz2SnCoUgjM0V87pur0+FC3rE727SqwPjYr+IJTw9UmDLDIGijsLk89hXbm5
qtZLl5p5CyqyQzptIEAZA4Btkx4lmQbuGdV9UteJzh1yKmANujmBtBRghA2m6Jk6
wyrpc7X5OX5I1T3LrU3fHTLGUJE/Q5qjd9YnSsH/Ut36MAFkUvwOnPR0tEEhE+uK
vGIg9iWN9VLUdG9qEFNLK1y1OV8BfZtQiRcreW9bkTX3M/13x56g01qIWCARS0lb
7gvTO3aATHI5BFoyjpxwC/LHUcS3JJMn+AskRPvjbclWxB2geLQo2KRBXPP/hKvC
5sUa9S71aE92HGE+0rUmVUBXH/R+eK+/nhOOyNf2PSodADLAnRnhzgYtRVLop/jm
EgU4OdJrUcRfdhO39OKd2zkZqxzibJhvNB25YXrT+6xrpl4ffhsNPCvtLwJgcNuS
ZHFDcv0HaZSzkyd5klWzYEvl3tYsN4USeK9aI1DCayOB6CkUSDVK2YQSZg32U3vG
U7n/gaEn65pw9bpqMqu5oe7N2+fJKb2QFnhIbalBAl84/Mr8lfL/a74uRwARAQAB
zQ1pbmZvQGVtaWNvLm5swsFwBBMBCgAaBQJY9xUtAhsvAwsJBwMVCggCHgECF4AC
GQEACgkQKvbI/tS7SVehTg/8D75ZnENLbOg8/sbtlJ+Ug7pXR0iTySG8YyQ0NVR2
8fNgeaUnYwjWBudH438XUjwkwzy3PWwiAMuC2X85JIVJXlzv+rvXGGXr1uz16Gt+
rUuLPssdkIPoh4RNfqigv9o3eil16iMMqubqjxZS5UzvAWKNyboisfb6pookY+X2
8uxc/IsYCG791ZLb4lBnRivCklW1dXxQG360WMHyBXEaACXhwJH9oCoCA/rcrpD9
oJlRqTIqYjlmvAeMJO5x7/7eohDWr2cT4WRYrJCC2RZbeAMe79xyazL0eD/rL6oE
mYVEALCvUYsk4vSEXX8TiNxWp0c/xdnGrsangxeARHv7/XVr+kSp3EXe8805tR0o
FVbBiHKyiqtoX0edUlabHkJvPDmqaofaXOnMRqEnmHWuAHOb1mjvGSj89hixIKib
XIpbUQbKQxErgetUIOk9yZxBYgvr/wteMqrQEucxUROMIv4KXPkVhTEaW3E9ro+w
O3pcH+NoV2ZE9VbiSQdvZVsDLbYarXFWi/A80ofXpMW2FZ+6X67EuwTIAG/qrcws
IoipDbFTIQ4GH1isDGzdQZHk6VzETwhpgYE1aJLhHFzAfBqim5XuFUmiEih9/iIV
3QdkePTm7+HfIvO3wURdaRH7Omp0rM3Lq06riPR3unyJ7Y43cpouq8BEKuDnOxpQ
BwnOwE0EWPcVLQEIALKboRlg4pz23YgEk1nicEmoDa9WoYbD9WqNI4tsKSHXGbdg
IqYPmpjp2yLU+xaQmWlLSkiGSx610z97uyUw9oDAHxreRlmiK/bcZXNjqwDYrdTi
XiM9P+5iz6CTwL2MYQGHgUp+bdwIHCa8AjGIKR1Ezeo6or7rccT7woL2HL2XWJK0
KHEcVoKruw5pJxEoCBCaubnmbq2WSFnQAMLruyA3k+CB6/Aq8f4BuceCsvMKjD4E
TwBl1rG/OjmDLrjh/defUbeTSW10aFxcBVAguDGN+HA1GL4y32aF40E0Yo+qQxX5
ScYZiFmg27W3MqMyGJYLldAYVSFZd7fHGPm3HYMAEQEAAcLChAQYAQoADwUCWPcV
LQUJDwmcAAIbLgEpCRAq9sj+1LtJV8BdIAQZAQoABgUCWPcVLQAKCRBtfd4QvMp/
GDR2B/9xHtgKYhENonms4H6tCFLmaU3BHpGip8vm6zFfY0rjl/4crT41Bu0E3rKg
dkYz7B8nCdn8ZZ90qz9zcW+CdogxaauOqFV0hIvLmpnMYwW93ZK6kSUqu0ZSR3JG
YgioJ7fyLWrV13VpV6mJs+jQZx40KAxg87jf0PT95cARWS4qi1iTuX5I8UpDd/1I
+zEYi5cSoDgG7hsm8gIQmfZSd+qXKWjDjgWN2NNEG58pXYGQbBsBg83j0El6O8ZJ
CfVsju6ZemLIOMmyEYyVwZ4b0y0tJWqASrI81/JD+U2ybA3aE2w8Vn/MuVpfEbc1
Ve3WPye4NGIR1fCCg5PaHckDqAlJHJYQAKIrlR+wqB4MAh+dgf7+hB5qYZVRKVvA
aAtUaABVrmr7Si6X0/Y4ACcYG9OXAhbjYrq47DnQQQF7DsHQPxRHkafcAiVGn9DW
KZii7W2n6XAjsyyF8pT6QEFZuAxbv01g5vSfiysERzk49HO3s7/nQZxn6321oG5L
HlYIs5pwz4Xx/XgO67EwCyjzbO2LmGw7EW0ArKYaupzt4OJvrZnzQoYkyFFxNSsO
wck46oczh3hblXojZVWY3ddjWVZx7x+CaZ1laE97fWpm3DYfAlDXobo+DNPRtApc
CdtB9nFavsMRlR6gZu4WeFP+ZMpUnNMNaYkJk/fPNb4zRglpiTwtPJeh9uxVQpci
4fZAMoxLPQOYqoHW58C6+WrAZppYSuHNobOFjCP2XKPaMTkh7w5BDQq/vcfkPcZh
G7QIZDukfEHWZCDi4uiF3gdY5E/TxM14PH2nhGG979jyOGyyLnZpm+cGqytc4kNX
/nIVPFE4w9trpvhtgPDMfkP+P1poomgWyQWYC4eicPxFIvwIXfMHRovZ6lUi5HHi
LYTUSYrtDx2J5qIorTya9fu0N217Nj8o56SFXQb6/78iJMisF+ZPu147g0L3xQJ/
MugttlXu+20KsS3E/9oB2k6uKYhOy6EaODDRBfjA6vVPlNCcBlJE2UPxG8B5xkzj
4SFp6tzuvhMJzsBNBFj3FS0BCADmNzTQJiSOAhpr7fpdqrDr0ln46OrcGPgf7SjJ
SajaEV1Bdq33xXGMC/TxjTqj35Cg7u4wWrmO+faHX/RrSuPUKRCVN7AF+qW4vs/5
O1CoA8uzhjVz885Burivm0lB8sjsViQLNwZO6z/BodmoXbuIoTl7XclMUnGJVQxC
lCpdP5YHQNaaULkR/MD+EIQWhIdzA7FyFA0NFSPshJnuF1OzriHsskCDso8SGS/l
HWC0dT/MVDr7MZrwo78uZQCEltD3W10a7cIBypop/6TGymOSltpzjFC4Z37Zpy4j
QoXyw77oASmB/md8FsxRT6KmJsxiRkvKtKPoYKgvP3a29ISjABEBAAHCwoQEGAEK
AA8FAlj3FS0FCQ8JnAACGy4BKQkQKvbI/tS7SVfAXSAEGQEKAAYFAlj3FS0ACgkQ
fGkZkFxiFAHVPggAmWuoaUFApbaqIPEChJ25W92rk/2Bry0I2ay6/E2XGfzX46sm
K9JKzbHA4/Ey72OK/eCCebbK+NJdMCieGa6Tlm92Lz+BJ/6NMxlrk0E+7FVY2ZlC
TMKhUOW4hTC+NNNVEnvRNQ0xQGlyy+3gRQi2LtIe97ro+1IJHnsyUZ0YX4gCx2KN
FoJCQYpYkey9MdjGsw+IcQz//UmyC57I8cut6qUy//yfFR1imRbvVNCDtE/n1yI+
zp73ZQnn0zWgIuVLwXNjVgjrJfiWur7VjuSpW4fr0QIli7dEmHy5GpUO9y6+JqqY
9Ld75NXm5oGnZccnqsyJ1msUmoIRBFrcAWdph30BD/97cejquS9aAHMxA/R5kFMa
8VOxVQ62broCRuGpaSKg6JOK+4dV+Efzl0ovmZkRC3j1Vo7QZiR9LMQk9wGwXnzw
CihNZr+P9za+lwbc4stXo4a2yCwA/2q10lWEj+YzKkk5TvpPlpfSBiuDL/jVTai2
RZViSeMpuRGaT58UWCOkkzW7tfNpgeQ7bdM+guRr2EVCu8f3GfkWP0zO14vfuY/D
ClUNUyP1Azk11g1km4C/27D3LjWdTxEAvr19qsvYxbsR/wdFLqE/kwHXRRRZOcbf
Q4uu77iVLNAwTNxtGaZOsiwqhSTO52QTQpWCppS0f5WXdsV6+0OrnxCeKwOTSapq
BIXkihEXnwb9LWM25OYAHE1WW89jCZcXSywTQs2HGg8an7zBm4XLP9BPHuTSx58X
1x5wevIjxnJL+e06cADpdSF6GJdVra5StzEG4FYnmIASidzIko2KBuY0Yzb09IJU
84qSK8rpkwVYsKx5kQvHQx7TR0yvdnA2EP1YDvHev03gzw8qGcqKuXo+tpjn0P1u
SmuEQX6WrvN9q5PAPjmeQcIQIzd5F36iJtlGn1Z8/oav6aG4jSW2IbjyS4iRabgS
QXWnKLNpjOMbszI/oUkavAXBKAFyjPOFVKrRy9zsmZCxE4lTr0BrFkIRuGMIywCr
XCUAAGDt8WKn3NJ3wy6a8w==
=j0ue
-----END PGP PUBLIC KEY BLOCK-----
ah-net commented 2 years ago

Will create an pull request for this