search

EmixamPP / linux-enable-ir-emitter

Provides support for infrared cameras that are not directly enabled out-of-the box.
MIT License
242 stars 21 forks source link

Add openrc support #104

Closed xz-dev closed 1 year ago

xz-dev commented 1 year ago

Tested at Gentoo

xz-dev commented 1 year ago

I had no time to test yet, if anyone have time, please test it.

EmixamPP commented 1 year ago

It looks good, if I find things to modify I'll take care of them. Thanks!

xz-dev commented 1 year ago

Nice to hear that, but I had ready to leave Gentoo and go to openSUSE, so I may cannot test it on OpenRC. The another thing for Gentoo user, here is my ebuild for linux-enable-ir-emitter if someone need take it, its not merged and I wont try again. BTW, openSUSE did not have the package, I will package it if I finally switch at here.

NicolaSmaniotto commented 1 year ago

@EmixamPP Hi, I use gentoo and would be happy to have OpenRC support merged. If you need help testing changes let me know.

EmixamPP commented 1 year ago

@NicolaSmaniotto I've finished implementing the support of OpenRC into linux-enable-ir-emitter, but I cannot test the OpenRC part.

Please clone https://github.com/xz-dev/linux-enable-ir-emitter, and follow the instruction of the manual build section in the README; I added a special section for openrc. If you told me that it is working, I can merge it into the master branch here. Thanks !

Note that openrc will not be officially supported be me. Consequently, I can accept PR that update and fix it, but I will not maintain the related source files.

xz-dev commented 1 year ago

I will test it in my vm latter

My VM is broken... so I canot test now

EmixamPP commented 1 year ago

(Don't worry about failed check, that's expected for now)

NicolaSmaniotto commented 1 year ago

Hi, I have tested the openrc version. No problems encountered.

I have compiled it with the alternative meson script and installed. # linux-enable-ir-emitter boot enable added the service to the correct runlevel. After shutting down and booting again, the service is correctly started and everything works. No issues after sleep, can't test hibernation.

One thing I noticed: $ linux-enable-ir-emitter -V outputs unsupported as the version, is this on purpose?.

EmixamPP commented 1 year ago

Great, thank you !

One thing I noticed: $ linux-enable-ir-emitter -V outputs unsupported as the version, is this on purpose?.

Don't worry, this was temporary, I'll change it to the correct version value in the next release

EmixamPP commented 1 year ago

Thank you @xz-dev for the initiative :smiley:

NicolaSmaniotto commented 1 year ago

Just want to mention that instead of having two different meson scripts it could be cleaner to leverage build options.

EmixamPP commented 1 year ago

You're right, I'll look into doing that