search

EmmanuelDemey / eslint-plugin-angular

ESLint plugin for AngularJS applications
https://www.npmjs.com/package/eslint-plugin-angular
618 stars 131 forks source link

Change default function-type rule option to prefer named functions #557

Closed miqh closed 6 years ago

miqh commented 6 years ago

Hello,

These changes alter the default option used by the angular/function-type rule so that named functions are preferred over anonymous ones. This alteration is in line with John Papa's style guidance for AngularJS (Y024).

Also had to fiddle with the test suite a bit to ensure it stayed green.

miqh commented 6 years ago

Looks like CI has been broken for a while.

Did a bit of searching and the problem might be related to underlying ESLint dependencies.

Strange enough, if I used npm instead of Yarn to install project dependencies then run the tests, all seems well. The way npm resolves dependencies seems to steer clear of this problem.

Here's a related issue.

EmmanuelDemey commented 6 years ago

Thanks a lot @miqh