search

EnableSecurity / sipvicious

SIPVicious OSS is a VoIP security testing toolset. It helps security teams, QA and developers test SIP-based VoIP systems and applications. This toolset is useful in simulating VoIP hacking attacks against PBX systems especially through identification, scanning, extension enumeration and password cracking.
https://www.enablesecurity.com/sipvicious/oss/
Other
896 stars 158 forks source link

svwar multi port support #64

Closed gbiagomba closed 4 years ago

gbiagomba commented 4 years ago

Hello,

While i was using svwar with the port flag it through up an error, i tried one port at a time and it liked that better. But i figured i let you know

"svwar -e100-200 127.0.0.1 -p 5060-5062,10000 -m INVITE"

Traceback (most recent call last):
  File "/usr/bin/svwar", line 11, in <module>
    load_entry_point('sipvicious==0.3.0', 'console_scripts', 'sipvicious_svwar')()
  File "/usr/share/sipvicious/sipvicious/svwar.py", line 601, in main
    sipvicious = TakeASip(
  File "/usr/share/sipvicious/sipvicious/svwar.py", line 86, in __init__
    self.dsthost, self.dstport = host, int(port)
ValueError: invalid literal for int() with base 10: '5060-5062,10000'
Traceback (most recent call last):
sandrogauci commented 4 years ago

Hi @gbiagomba thanks for noticing a 13 year old bug! Only svmap is meant to take port ranges (as it takes IP ranges too) - svwar and svcrack never really supported the functionality. Typically, you would want to identify a SIP device's IP and port using svmap, then use the other two tools for the attack phase.

So the bug is in the actual flag help, which is shared across all 3 tools but should actually be separated. We'll make two updates:

0xInfection commented 4 years ago

66 should do it. :)

gbiagomba commented 4 years ago

@sandrogauci was i the first to spot this out? i cant be lol

sandrogauci commented 4 years ago

@gbiagomba certainly first to complain about it :)

gbiagomba commented 4 years ago

Ohh wow lol