search

EndlessFractal / yourTurn

Foundry Module that adds a visual display whenever the turn changes.
5 stars 2 forks source link

[Bug 1.2.9] 'Hidden' Tokens Display an Enormous Token Image for Players for Hidden Tokens #10

Closed Red5MT closed 9 months ago

Red5MT commented 9 months ago

When a hidden token's turn starts, instead of a 'normal' size generic token image displayed over the ribbon, Your Turn! displays a token image that practically fills the screen. Below is an example, the GM screen on the left showing the token with Visibility toggled off and the player side on the right (its a wee bit large, no?). ;)

YourTurn

I tested this running a GM window and PC window on the same PC (different browsers).

NOTE: I would also suggest that instead of a generic moster token for the 'hidden' image, you may want to use a question mark. It may be a custom event that uses a 'hidden' token instead of a monster.

EndlessFractal commented 9 months ago

This is what it happens when I don't properly unit test before releasing... facepalm

It will be fixed in the next release.

NOTE: I would also suggest that instead of a generic moster token for the 'hidden' image, you may want to use a question mark. It may be a custom event that uses a 'hidden' token instead of a monster.

I just found that image more visually appealing than a simple question mark.

Perhaps I could add in a feature to a named token "hiddenevent" and place another image for it... https://game-icons.net/1x1/delapouite/perspective-dice-six-faces-random.html

Cheers!

Red5MT commented 9 months ago

This is what it happens when I don't properly unit test before releasing... facepalm

Yeah, probably... :) It is a hobby though.

I just found that image more visually appealing than a simple question mark.

Perhaps I could add in a feature to a named token "hiddenevent" and place another image for it... https://game-icons.net/1x1/delapouite/perspective-dice-six-faces-random.html

I dig the die too. Just thought I would throw out my opinion. It's your module for your game...and you were nice enough to share it...not gonna complain here. :) Honestly, I am surprised that Ripper has not added this functionality to Combat Carousel Tracker. Your Turn and CCT are a pretty good combo.

Red5MT commented 9 months ago

I assume you will see this comment even though the thread is closed.

First, tested and looks good. I am happy to be able to add this back into my game. Second, as a minor visual improvement, might I suggest making the 'hidden' token image a wee bit larger to be more consistant with the sizes of other tokens. See the image below: YourTurnTokenSize