search

Energinet-DataHub / ARCHIVED-geh-aggregations

This project aims to create an engine that is able to do calculations on billions of metering points and deliver the results within minutes
Apache License 2.0
2 stars 0 forks source link

Feature/616 event to masterdata poc #712

Closed kristianschneider closed 2 years ago

kristianschneider commented 2 years ago

This contains the POC for events to master data in .NET

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [3129511](https://dashboard.gitguardian.com/incidents/3129511?occurrence=30865954) | Microsoft Azure Storage Account Key | 54ec9f88f3958dda9bac0060f11706149cabba08 | source/coordinator/Energinet.DataHub.Aggregation.Coordinator.CoordinatorFunction/local.settings.sample.json | [View secret](https://github.com/Energinet-DataHub/geh-aggregations/commit/54ec9f88f3958dda9bac0060f11706149cabba08#diff-f615f516099e1f8ebf8a028503fa9901e74131a4151b79d765c4a492ef63b2a3R5) | | [3129511](https://dashboard.gitguardian.com/incidents/3129511?occurrence=30865955) | Microsoft Azure Storage Account Key | 54ec9f88f3958dda9bac0060f11706149cabba08 | source/coordinator/Energinet.DataHub.Aggregation.Coordinator.CoordinatorFunction/local.settings.sample.json | [View secret](https://github.com/Energinet-DataHub/geh-aggregations/commit/54ec9f88f3958dda9bac0060f11706149cabba08#diff-f615f516099e1f8ebf8a028503fa9901e74131a4151b79d765c4a492ef63b2a3R6) | | [3129511](https://dashboard.gitguardian.com/incidents/3129511?occurrence=30943140) | Microsoft Azure Storage Account Key | 431a61a4eb2e83ff14d47463e319cd8f891c3104 | source/coordinator/Energinet.DataHub.Aggregation.Coordinator.CoordinatorFunction/local.settings.sample.json | [View secret](https://github.com/Energinet-DataHub/geh-aggregations/commit/431a61a4eb2e83ff14d47463e319cd8f891c3104#diff-f615f516099e1f8ebf8a028503fa9901e74131a4151b79d765c4a492ef63b2a3R5) | | [3129511](https://dashboard.gitguardian.com/incidents/3129511?occurrence=30943141) | Microsoft Azure Storage Account Key | 431a61a4eb2e83ff14d47463e319cd8f891c3104 | source/coordinator/Energinet.DataHub.Aggregation.Coordinator.CoordinatorFunction/local.settings.sample.json | [View secret](https://github.com/Energinet-DataHub/geh-aggregations/commit/431a61a4eb2e83ff14d47463e319cd8f891c3104#diff-f615f516099e1f8ebf8a028503fa9901e74131a4151b79d765c4a492ef63b2a3R6) | | [3129511](https://dashboard.gitguardian.com/incidents/3129511?occurrence=30971492) | Microsoft Azure Storage Account Key | fd74ee75de8ba8db126bbc3ddf1beed61bdb3c04 | source/coordinator/Energinet.DataHub.Aggregation.Coordinator.CoordinatorFunction/local.settings.sample.json | [View secret](https://github.com/Energinet-DataHub/geh-aggregations/commit/fd74ee75de8ba8db126bbc3ddf1beed61bdb3c04#diff-f615f516099e1f8ebf8a028503fa9901e74131a4151b79d765c4a492ef63b2a3R5) | | [3129511](https://dashboard.gitguardian.com/incidents/3129511?occurrence=30971493) | Microsoft Azure Storage Account Key | fd74ee75de8ba8db126bbc3ddf1beed61bdb3c04 | source/coordinator/Energinet.DataHub.Aggregation.Coordinator.CoordinatorFunction/local.settings.sample.json | [View secret](https://github.com/Energinet-DataHub/geh-aggregations/commit/fd74ee75de8ba8db126bbc3ddf1beed61bdb3c04#diff-f615f516099e1f8ebf8a028503fa9901e74131a4151b79d765c4a492ef63b2a3R6) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/microsoft_azure_storage_account_key#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 2 years ago

Codecov Report

Merging #712 (31a5d18) into main (0e51ac6) will increase coverage by 0.28%. The diff coverage is 30.24%.

:exclamation: Current head 31a5d18 differs from pull request most recent head e380fc0. Consider uploading reports for the commit e380fc0 to get more accurate results

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   25.32%   25.61%   +0.28%     
==========================================
  Files         113      126      +13     
  Lines        1520     1749     +229     
  Branches      169      183      +14     
==========================================
+ Hits          385      448      +63     
- Misses       1106     1270     +164     
- Partials       29       31       +2
Impacted Files Coverage Δ
...vents/MeteringPoints/EnergySupplierChangedEvent.cs 100.00% <ø> (ø)
...ion/Transformation/EventToMasterDataTransformer.cs 0.00% <0.00%> (ø)
...t.DataHub.Aggregations.Domain/MasterData/Charge.cs 0.00% <0.00%> (ø)
...taHub.Aggregations.Domain/MasterData/ChargeLink.cs 0.00% <0.00%> (ø)
...aHub.Aggregations.Domain/MasterData/ChargePrice.cs 0.00% <0.00%> (ø)
...ub.Aggregations.Domain/MasterData/EsBrpRelation.cs 0.00% <0.00%> (ø)
....Aggregations.Domain/MasterData/GridLossSysCorr.cs 0.00% <0.00%> (ø)
...taHub.Aggregations.Domain/MasterData/MarketRole.cs 0.00% <0.00%> (ø)
...frastructure/Middleware/CorrelationIdMiddleware.cs 0.00% <0.00%> (ø)
.../Middleware/FunctionInvocationLoggingMiddleware.cs 0.00% <0.00%> (ø)
... and 18 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication