Energinet-DataHub / ARCHIVED-geh-aggregations

This project aims to create an engine that is able to do calculations on billions of metering points and deliver the results within minutes
Apache License 2.0
2 stars 0 forks source link

Add required AppInsight dependencies #717

Closed lasrinnil closed 2 years ago

lasrinnil commented 2 years ago

Description

The Integration-Events-Listener was missing some dependencies, this PR will add those required.

616

codecov[bot] commented 2 years ago

Codecov Report

Merging #717 (5f7bf27) into main (f2a145d) will increase coverage by 11.62%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #717       +/-   ##
===========================================
+ Coverage   15.44%   27.07%   +11.62%     
===========================================
  Files          80      120       +40     
  Lines        1094     1651      +557     
  Branches      105      170       +65     
===========================================
+ Hits          169      447      +278     
- Misses        920     1186      +266     
- Partials        5       18       +13     
Impacted Files Coverage Δ
...b.Aggregations.IntegrationEventListener/Program.cs 0.00% <0.00%> (ø)
....Aggregations.Domain/MasterData/GridLossSysCorr.cs 0.00% <0.00%> (ø)
...r/MeteringPoints/MeteringPointConnectedListener.cs 0.00% <0.00%> (ø)
...tener/MarketRoles/EnergySupplierChangedListener.cs 0.00% <0.00%> (ø)
...s.IntegrationEventListener/Common/EventMetadata.cs 100.00% <0.00%> (ø)
...gregations.Application/Extensions/EnumExtension.cs 0.00% <0.00%> (ø)
...tions.Infrastructure/Messaging/MessageExtractor.cs 0.00% <0.00%> (ø)
...tionEvents/Mutators/MeteringPointCreatedMutator.cs 91.66% <0.00%> (ø)
...frastructure/Mappers/ProtobufToDomainTypeMapper.cs 97.91% <0.00%> (ø)
...ub.Aggregations.Domain/MasterData/MeteringPoint.cs 100.00% <0.00%> (ø)
... and 31 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lasrinnil commented 2 years ago

How did you discover that? Is there any kind of test that could prevent such errors again?

I believe that an integration test with the function host would have exposed the error. Such a test is expected to be implemented in the near future.