Energinet-DataHub / ARCHIVED-geh-aggregations

This project aims to create an engine that is able to do calculations on billions of metering points and deliver the results within minutes
Apache License 2.0
2 stars 0 forks source link

Fix warnings #718

Closed lasrinnil closed 2 years ago

lasrinnil commented 2 years ago

Description

This PR will address all warnings and enable treating warnings as errors.

References

codecov[bot] commented 2 years ago

Codecov Report

Merging #718 (ef5c021) into main (4cf1dc9) will increase coverage by 11.11%. The diff coverage is 65.78%.

@@             Coverage Diff             @@
##             main     #718       +/-   ##
===========================================
+ Coverage   15.44%   26.55%   +11.11%     
===========================================
  Files          80      122       +42     
  Lines        1094     1683      +589     
  Branches      105      171       +66     
===========================================
+ Hits          169      447      +278     
- Misses        920     1217      +297     
- Partials        5       19       +14     
Impacted Files Coverage Δ
....DataHub.Aggregations.DatabaseMigration/Program.cs 0.00% <0.00%> (ø)
...DataHub.Aggregations.DatabaseMigration/Upgrader.cs 100.00% <ø> (ø)
...gregations.Application/Extensions/EnumExtension.cs 0.00% <0.00%> (ø)
...s/DTOs/MeteringPoints/MeteringPointCreatedEvent.cs 93.33% <0.00%> (ø)
...TOs/MeteringPoints/SettlementMethodChangedEvent.cs 87.50% <0.00%> (ø)
...lication/IntegrationEvents/Mutators/MutatorBase.cs 95.00% <0.00%> (ø)
...IntegrationEventListener/Common/EventDataHelper.cs 90.90% <ø> (ø)
...Coordinator.Application/Utilities/EnumExtension.cs 50.00% <0.00%> (ø)
...Infrastructure/BlobStorage/PersistedDataService.cs 0.00% <0.00%> (ø)
...n.Coordinator.Infrastructure/MetaDataDataAccess.cs 0.00% <ø> (ø)
... and 46 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

lasrinnil commented 2 years ago

I would prefer if you did like in geh-timeseries: https://github.com/Energinet-DataHub/geh-timeseries/blob/main/source/Directory.Build.props

done.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication