Energinet-DataHub / ARCHIVED-geh-aggregations

This project aims to create an engine that is able to do calculations on billions of metering points and deliver the results within minutes
Apache License 2.0
2 stars 0 forks source link

Fix prepare job parameters in trigger #735

Closed BjarkeMeier closed 2 years ago

BjarkeMeier commented 2 years ago

Description

Make prepare job trigger invoke the prepare job with the correct number of arguments and correct names of arguments.

Python lib ConfigArgParse has been replaced by Click.

Tests have been added to ensure that the parameters of caller and callee stay in sync. That is one test for caller and one for callee. The connection is the shared text file playing the role of kinda contract.

References

codecov[bot] commented 2 years ago

Codecov Report

Merging #735 (f41b2df) into main (233a7a8) will increase coverage by 0.30%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   26.55%   26.86%   +0.30%     
==========================================
  Files         122      122              
  Lines        1683     1690       +7     
  Branches      171      171              
==========================================
+ Hits          447      454       +7     
  Misses       1217     1217              
  Partials       19       19              
Impacted Files Coverage Δ
...tor.Application/Coordinator/CoordinatorSettings.cs 90.00% <ø> (-0.48%) :arrow_down:
...inator.Application/Coordinator/TriggerArguments.cs 92.85% <100.00%> (+0.92%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication