Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

fix: cim conversion errors result in schema, B2B sync or async errors #1879

Closed x-platformcoder closed 1 year ago

x-platformcoder commented 1 year ago

Description

Bug fixed so schema validations are catched correctly and

References

codecov[bot] commented 1 year ago

Codecov Report

Merging #1879 (e867232) into main (7072b75) will increase coverage by 51.76%. The diff coverage is 11.76%.

@@             Coverage Diff             @@
##             main    #1879       +/-   ##
===========================================
+ Coverage   32.22%   83.99%   +51.76%     
===========================================
  Files          24      451      +427     
  Lines         512     7983     +7471     
  Branches       23       23               
===========================================
+ Hits          165     6705     +6540     
- Misses        332     1134      +802     
- Partials       15      144      +129     
Flag Coverage Δ
business 87.53% <11.76%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ub.Charges.FunctionHost/Charges/ChargeIngestion.cs 0.00% <0.00%> (ø)
...ation/ChargeBundle/ChargeCommandBundleConverter.cs 98.66% <100.00%> (ø)
...eserialization/MarketDocument/DocumentConverter.cs 98.71% <100.00%> (ø)
...lidation/ValidationRules/ChargeDoesNotExistRule.cs 100.00% <0.00%> (ø)
...dation/ValidationRules/ResolutionIsRequiredRule.cs 80.00% <0.00%> (ø)
...re.Core/Cim/Charges/MarketParticipantRoleMapper.cs 89.65% <0.00%> (ø)
...es/source/GreenEnergyHub.Charges.WebApi/Startup.cs 98.57% <0.00%> (ø)
...argePriceConfirmedDataAvailableNotifierEndpoint.cs 0.00% <0.00%> (ø)
...ata/ChargePriceOperationsAcceptedReceiptFactory.cs 100.00% <0.00%> (ø)
...ges.ApplyDBMigrationsApp/Helpers/ScriptComparer.cs 100.00% <0.00%> (ø)
... and 420 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication